superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Only show overlay if container is set (#4601)
Date Mon, 19 Mar 2018 18:23:22 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new ba9379b  Only show overlay if container is set (#4601)
ba9379b is described below

commit ba9379b9491d38afe4172b9abd98d3818601ec3c
Author: Beto Dealmeida <roberto@dealmeida.net>
AuthorDate: Mon Mar 19 11:23:19 2018 -0700

    Only show overlay if container is set (#4601)
    
    * Pass width in props
    
    * Only load overlay if container is set
---
 superset/assets/javascripts/chart/Chart.jsx | 1 +
 1 file changed, 1 insertion(+)

diff --git a/superset/assets/javascripts/chart/Chart.jsx b/superset/assets/javascripts/chart/Chart.jsx
index 54736e5..4b44106 100644
--- a/superset/assets/javascripts/chart/Chart.jsx
+++ b/superset/assets/javascripts/chart/Chart.jsx
@@ -223,6 +223,7 @@ class Chart extends React.PureComponent {
           !this.props.chartAlert &&
           this.props.refreshOverlayVisible &&
           !this.props.errorMessage &&
+          this.container &&
           <RefreshChartOverlay
             height={this.height()}
             width={this.width()}

-- 
To stop receiving notification emails like this one, please contact
maximebeauchemin@apache.org.

Mime
View raw message