superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Allowing config flag to turn off flask-compress (#4617)
Date Fri, 16 Mar 2018 00:17:09 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 1e0bcba  Allowing config flag to turn off flask-compress (#4617)
1e0bcba is described below

commit 1e0bcba568aeea3913858908a56676e64e849ad2
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Thu Mar 15 17:17:04 2018 -0700

    Allowing config flag to turn off flask-compress (#4617)
---
 docs/installation.rst | 3 +++
 superset/__init__.py  | 3 ++-
 superset/config.py    | 4 ++++
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/docs/installation.rst b/docs/installation.rst
index 1e6e27d..5cb4260 100644
--- a/docs/installation.rst
+++ b/docs/installation.rst
@@ -173,6 +173,9 @@ work on Windows so the `superset runserver` command is not expected to
work
 in that context. Also note that the development web
 server (`superset runserver -d`) is not intended for production use.
 
+If not using gunicorn, you may want to disable the use of flask-compress
+by setting `ENABLE_FLASK_COMPRESS = False` in your `superset_config.py`
+
 Flask-AppBuilder Permissions
 ----------------------------
 
diff --git a/superset/__init__.py b/superset/__init__.py
index fbf11c0..d420b76 100644
--- a/superset/__init__.py
+++ b/superset/__init__.py
@@ -168,7 +168,8 @@ module_datasource_map.update(app.config.get('ADDITIONAL_MODULE_DS_MAP'))
 ConnectorRegistry.register_sources(module_datasource_map)
 
 # Flask-Compress
-Compress(app)
+if conf.get('ENABLE_FLASK_COMPRESS'):
+    Compress(app)
 
 # Hook that provides administrators a handle on the Flask APP
 # after initialization
diff --git a/superset/config.py b/superset/config.py
index 87da811..a7e7210 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -405,6 +405,10 @@ DB_CONNECTION_MUTATOR = None
 #        return "-- [SQL LAB] {username} {dttm}\n sql"(**locals())
 SQL_QUERY_MUTATOR = None
 
+# When not using gunicorn, (nginx for instance), you may want to disable
+# using flask-compress
+ENABLE_FLASK_COMPRESS = True
+
 try:
     if CONFIG_PATH_ENV_VAR in os.environ:
         # Explicitly import config module that is not in pythonpath; useful

-- 
To stop receiving notification emails like this one, please contact
maximebeauchemin@apache.org.

Mime
View raw message