superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Improve default placeholder text on SelectControl (#4442)
Date Fri, 16 Feb 2018 23:16:57 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 88e91e6  Improve default placeholder text on SelectControl (#4442)
88e91e6 is described below

commit 88e91e6d8fb3c1547ddc6f42ddf8d7a0e8939c47
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Fri Feb 16 15:16:55 2018 -0800

    Improve default placeholder text on SelectControl (#4442)
---
 .../assets/javascripts/explore/components/controls/SelectControl.jsx    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/assets/javascripts/explore/components/controls/SelectControl.jsx b/superset/assets/javascripts/explore/components/controls/SelectControl.jsx
index 3e8c7be..8b78fc0 100644
--- a/superset/assets/javascripts/explore/components/controls/SelectControl.jsx
+++ b/superset/assets/javascripts/explore/components/controls/SelectControl.jsx
@@ -106,7 +106,7 @@ export default class SelectControl extends React.PureComponent {
   }
   render() {
     //  Tab, comma or Enter will trigger a new option created for FreeFormSelect
-    const placeholder = this.props.placeholder || t('Select %s', this.state.options.length);
+    const placeholder = this.props.placeholder || t('%s option(s)', this.state.options.length);
     const selectProps = {
       multi: this.props.multi,
       name: `select-${this.props.name}`,

-- 
To stop receiving notification emails like this one, please contact
maximebeauchemin@apache.org.

Mime
View raw message