superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Removed double call to ConnectorRegistry.sources (#4448)
Date Fri, 16 Feb 2018 23:16:29 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new dc48673  Removed double call to ConnectorRegistry.sources (#4448)
dc48673 is described below

commit dc486736478e90f17b373b088d878ecd49fa934e
Author: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
AuthorDate: Sat Feb 17 01:16:25 2018 +0200

    Removed double call to ConnectorRegistry.sources (#4448)
    
    Removing the double call didn't cause any adverse effects upon removal. If required, a
comment motivating the double call should be added.
---
 superset/views/core.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/superset/views/core.py b/superset/views/core.py
index 0cb52fd..46e1650 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -2083,7 +2083,6 @@ class Superset(BaseSupersetView):
         SqlaTable = ConnectorRegistry.sources['table']
         data = json.loads(request.form.get('data'))
         table_name = data.get('datasourceName')
-        SqlaTable = ConnectorRegistry.sources['table']
         table = (
             db.session.query(SqlaTable)
             .filter_by(table_name=table_name)

-- 
To stop receiving notification emails like this one, please contact
maximebeauchemin@apache.org.

Mime
View raw message