superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Unset 'series limit' default from 50 to null (#4410)
Date Tue, 13 Feb 2018 19:17:22 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new d2d9731  Unset 'series limit' default from 50 to null (#4410)
d2d9731 is described below

commit d2d973153f2efc9e64420d295f1d61dc02fc5867
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Tue Feb 13 11:17:19 2018 -0800

    Unset 'series limit' default from 50 to null (#4410)
    
    Setting "Series Limit" by default results in a subquery (or 2 phase)
    which can be suboptimal / unecessary where low cardinality dims
    are used.
---
 superset/assets/javascripts/explore/stores/controls.jsx | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/superset/assets/javascripts/explore/stores/controls.jsx b/superset/assets/javascripts/explore/stores/controls.jsx
index e8a34d9..007523c 100644
--- a/superset/assets/javascripts/explore/stores/controls.jsx
+++ b/superset/assets/javascripts/explore/stores/controls.jsx
@@ -870,8 +870,11 @@ export const controls = {
     label: t('Series limit'),
     validators: [v.integer],
     choices: formatSelectOptions(SERIES_LIMITS),
-    default: 50,
-    description: t('Limits the number of time series that get displayed'),
+    description: t(
+      'Limits the number of time series that get displayed. A sub query ' +
+      '(or an extra phase where sub queries are not supported) is applied to limit ' +
+      'the number of time series that get fetched and displayed. This feature is useful '
+
+      'when grouping by high cardinality dimension(s).'),
   },
 
   timeseries_limit_metric: {

-- 
To stop receiving notification emails like this one, please contact
maximebeauchemin@apache.org.

Mime
View raw message