superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Prevent FilterBox extra query (#4276)
Date Thu, 25 Jan 2018 00:09:06 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new b72d5b0  Prevent FilterBox extra query (#4276)
b72d5b0 is described below

commit b72d5b03dcd5eb3786c9c3a0164f154a3a1edd85
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Wed Jan 24 16:09:03 2018 -0800

    Prevent FilterBox extra query (#4276)
    
    closes https://github.com/apache/incubator-superset/issues/4249
---
 superset/viz.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/superset/viz.py b/superset/viz.py
index bb0bcf6..27eac63 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -1546,6 +1546,9 @@ class FilterBoxViz(BaseViz):
     credits = 'a <a href="https://github.com/airbnb/superset">Superset</a> original'
 
     def query_obj(self):
+        return None
+
+    def filter_query_obj(self):
         qry = super(FilterBoxViz, self).query_obj()
         groupby = self.form_data.get('groupby')
         if len(groupby) < 1 and not self.form_data.get('date_filter'):
@@ -1555,7 +1558,7 @@ class FilterBoxViz(BaseViz):
         return qry
 
     def get_data(self, df):
-        qry = self.query_obj()
+        qry = self.filter_query_obj()
         filters = [g for g in self.form_data['groupby']]
         d = {}
         for flt in filters:

-- 
To stop receiving notification emails like this one, please contact
maximebeauchemin@apache.org.

Mime
View raw message