superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Bugfix: Druid having filters are broken (#4089)
Date Tue, 19 Dec 2017 01:06:16 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new ff4f9b4  Bugfix: Druid having filters are broken (#4089)
ff4f9b4 is described below

commit ff4f9b452777e80333e2cb494298e68171aef9f7
Author: fabianmenges <fabianmenges@users.noreply.github.com>
AuthorDate: Mon Dec 18 20:06:12 2017 -0500

    Bugfix: Druid having filters are broken (#4089)
---
 superset/connectors/druid/models.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/connectors/druid/models.py b/superset/connectors/druid/models.py
index 0b15068..a1d9ec0 100644
--- a/superset/connectors/druid/models.py
+++ b/superset/connectors/druid/models.py
@@ -1130,7 +1130,7 @@ class DruidDatasource(Model, BaseDatasource):
             qry['metric'] = list(qry['aggregations'].keys())[0]
             client.topn(**qry)
             logging.info('Phase 2 Complete')
-        elif len(groupby) > 0:
+        elif len(groupby) > 0 or having_filters:
             # If grouping on multiple fields or using a having filter
             # we have to force a groupby query
             logging.info('Running groupby query for dimensions [{}]'.format(dimensions))

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <commits@superset.apache.org>'].

Mime
View raw message