superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: [geo] turn off renderTrigger on viewport control (#4066)
Date Fri, 15 Dec 2017 22:59:56 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new fc85756  [geo] turn off renderTrigger on viewport control (#4066)
fc85756 is described below

commit fc85756c20dc9c9ab94eb11adb5a6c5865afa0a5
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Fri Dec 15 14:59:54 2017 -0800

    [geo] turn off renderTrigger on viewport control (#4066)
    
    For context, the viewport gets updated dynamically from the user
    actions on the map. This is done on a timer every second or so to keep
    the form data updated with the viewport settings.
    
    With renderTrigger=true on that control that generates re-renders which
    introduces glitches while zooming/panning. So turning it off as we don't
    really expect users to input viewport info directly in the control
    anyways.
---
 superset/assets/javascripts/explore/stores/controls.jsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/assets/javascripts/explore/stores/controls.jsx b/superset/assets/javascripts/explore/stores/controls.jsx
index b18039f..cf657ac 100644
--- a/superset/assets/javascripts/explore/stores/controls.jsx
+++ b/superset/assets/javascripts/explore/stores/controls.jsx
@@ -1446,7 +1446,7 @@ export const controls = {
   viewport: {
     type: 'ViewportControl',
     label: t('Viewport'),
-    renderTrigger: true,
+    renderTrigger: false,
     description: t('Parameters related to the view and perspective on the map'),
     // default is whole world mostly centered
     default: defaultViewport,

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <commits@superset.apache.org>'].

Mime
View raw message