superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Remove unused callbacks when setting state (#4015)
Date Thu, 07 Dec 2017 05:56:30 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 81df708  Remove unused callbacks when setting state (#4015)
81df708 is described below

commit 81df7087db83efb7a06c562843e83d4f6450d45e
Author: Beto Dealmeida <roberto@dealmeida.net>
AuthorDate: Wed Dec 6 21:56:28 2017 -0800

    Remove unused callbacks when setting state (#4015)
---
 .../explore/components/controls/DateFilterControl.jsx        | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/superset/assets/javascripts/explore/components/controls/DateFilterControl.jsx
b/superset/assets/javascripts/explore/components/controls/DateFilterControl.jsx
index eb35c01..fc365bd 100644
--- a/superset/assets/javascripts/explore/components/controls/DateFilterControl.jsx
+++ b/superset/assets/javascripts/explore/components/controls/DateFilterControl.jsx
@@ -58,23 +58,23 @@ export default class DateFilterControl extends React.Component {
     }
   }
   onControlChange(target, opt) {
-    this.setState({ [target]: opt.value }, this.onChange);
+    this.setState({ [target]: opt.value });
   }
   onNumberChange(event) {
-    this.setState({ num: event.target.value }, this.onChange);
+    this.setState({ num: event.target.value });
   }
   onFreeChange(event) {
-    this.setState({ free: event.target.value }, this.onChange);
+    this.setState({ free: event.target.value });
   }
   setType(type) {
-    this.setState({ type }, this.onChange);
+    this.setState({ type });
   }
   setValue(val) {
-    this.setState({ type: 'free', free: val }, this.onChange);
+    this.setState({ type: 'free', free: val });
     this.close();
   }
   setDatetime(dttm) {
-    this.setState({ dttm: dttm.format().substring(0, 19) }, this.onChange);
+    this.setState({ dttm: dttm.format().substring(0, 19) });
   }
   close() {
     let val;

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <commits@superset.apache.org>'].

Mime
View raw message