Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BC496200D43 for ; Tue, 21 Nov 2017 21:58:51 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id BAB1C160BFC; Tue, 21 Nov 2017 20:58:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0D7E9160BE3 for ; Tue, 21 Nov 2017 21:58:50 +0100 (CET) Received: (qmail 44843 invoked by uid 500); 21 Nov 2017 20:58:50 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 44834 invoked by uid 99); 21 Nov 2017 20:58:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Nov 2017 20:58:50 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 7C2CB81C45; Tue, 21 Nov 2017 20:58:49 +0000 (UTC) Date: Tue, 21 Nov 2017 20:58:49 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: Revert "Filter out unavailable databases (#3875)" (#3918) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <151129792914.16722.15662800201869680825@gitbox.apache.org> From: graceguo@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 2d37dec5ffa9fc9b1662b8eda901765f7305c365 X-Git-Newrev: 680e1cbb42b62b2bd2aac2968f9d03547fd0b060 X-Git-Rev: 680e1cbb42b62b2bd2aac2968f9d03547fd0b060 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated archived-at: Tue, 21 Nov 2017 20:58:51 -0000 This is an automated email from the ASF dual-hosted git repository. graceguo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 680e1cb Revert "Filter out unavailable databases (#3875)" (#3918) 680e1cb is described below commit 680e1cbb42b62b2bd2aac2968f9d03547fd0b060 Author: Maxime Beauchemin AuthorDate: Tue Nov 21 12:58:47 2017 -0800 Revert "Filter out unavailable databases (#3875)" (#3918) This reverts commit ae2205aeb54f43b63e58aadfbb5dd749e1c98d98. --- superset/views/core.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/superset/views/core.py b/superset/views/core.py index af2396e..18f6622 100755 --- a/superset/views/core.py +++ b/superset/views/core.py @@ -130,14 +130,6 @@ class SliceFilter(SupersetFilter): return query.filter(self.model.perm.in_(perms)) -class DatabaseFilter(SupersetFilter): - def apply(self, query, func): - if self.has_all_datasource_access(): - return query - perms = self.get_view_menus('database_access') - return query.filter(self.model.perm.in_(perms)) - - class DashboardFilter(SupersetFilter): """List dashboards for which users have access to at least one slice""" @@ -211,7 +203,6 @@ class DatabaseView(SupersetModelView, DeleteMixin): # noqa ] add_template = 'superset/models/database/add.html' edit_template = 'superset/models/database/edit.html' - base_filters = [['perm', DatabaseFilter, lambda:[]]] base_order = ('changed_on', 'desc') description_columns = { 'sqlalchemy_uri': utils.markdown( -- To stop receiving notification emails like this one, please contact ['"commits@superset.apache.org" '].