Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9A925200D43 for ; Tue, 21 Nov 2017 19:23:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9915B160BFC; Tue, 21 Nov 2017 18:23:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E16BC160BE3 for ; Tue, 21 Nov 2017 19:23:02 +0100 (CET) Received: (qmail 66566 invoked by uid 500); 21 Nov 2017 18:23:02 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 66552 invoked by uid 99); 21 Nov 2017 18:23:02 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Nov 2017 18:23:02 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 9817B81812; Tue, 21 Nov 2017 18:23:01 +0000 (UTC) Date: Tue, 21 Nov 2017 18:23:01 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: When checking if you should renderTriggered make sure key exists in controls (#3912) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <151128858148.31529.8111521268721549108@gitbox.apache.org> From: graceguo@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: feb15a30a286943d597f2e710a4a8193125ab5a3 X-Git-Newrev: 12fb7c1a627966a1350fca61a09dc9864eb972aa X-Git-Rev: 12fb7c1a627966a1350fca61a09dc9864eb972aa X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated archived-at: Tue, 21 Nov 2017 18:23:03 -0000 This is an automated email from the ASF dual-hosted git repository. graceguo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 12fb7c1 When checking if you should renderTriggered make sure key exists in controls (#3912) 12fb7c1 is described below commit 12fb7c1a627966a1350fca61a09dc9864eb972aa Author: michellethomas AuthorDate: Tue Nov 21 10:22:55 2017 -0800 When checking if you should renderTriggered make sure key exists in controls (#3912) --- superset/assets/javascripts/explore/components/ExploreViewContainer.jsx | 1 + 1 file changed, 1 insertion(+) diff --git a/superset/assets/javascripts/explore/components/ExploreViewContainer.jsx b/superset/assets/javascripts/explore/components/ExploreViewContainer.jsx index 43f6c01..835cc1a 100644 --- a/superset/assets/javascripts/explore/components/ExploreViewContainer.jsx +++ b/superset/assets/javascripts/explore/components/ExploreViewContainer.jsx @@ -53,6 +53,7 @@ class ExploreViewContainer extends React.Component { } // if any control value changed and it's an instant control if (Object.keys(np.controls).some(key => (np.controls[key].renderTrigger && + typeof this.props.controls[key] !== 'undefined' && !areObjectsEqual(np.controls[key].value, this.props.controls[key].value)))) { this.props.actions.renderTriggered(new Date().getTime(), this.props.chart.chartKey); } -- To stop receiving notification emails like this one, please contact ['"commits@superset.apache.org" '].