superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Fixing the build's linting errors (#3887)
Date Thu, 16 Nov 2017 19:18:36 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new e65aba3  Fixing the build's linting errors (#3887)
e65aba3 is described below

commit e65aba3c46c294a552bc74006519e2cb106cc69a
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Thu Nov 16 11:18:33 2017 -0800

    Fixing the build's linting errors (#3887)
    
    master has new linting rules, PRs got merged with lint that was ok at
    branching but not ok in masert anymore
---
 superset/cli.py |  4 ++--
 superset/viz.py | 24 ++++++++++++------------
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/superset/cli.py b/superset/cli.py
index a9f89af..ddbdf4b 100755
--- a/superset/cli.py
+++ b/superset/cli.py
@@ -133,14 +133,14 @@ def load_examples(load_test_data):
     print('Loading [Misc Charts] dashboard')
     data.load_misc_dashboard()
 
-    print("Loading DECK.gl demo")
+    print('Loading DECK.gl demo')
     data.load_deck_dash()
 
     if load_test_data:
         print('Loading [Unicode test data]')
         data.load_unicode_test_data()
 
-    print("Loading flights data")
+    print('Loading flights data')
     data.load_flights()
 
 
diff --git a/superset/viz.py b/superset/viz.py
index 932f204..6b369be 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -1769,8 +1769,8 @@ class BaseDeckGLViz(BaseViz):
             d = dict(position=self.get_position(d), **self.get_properties(d))
             features.append(d)
         return {
-            "features": features,
-            "mapboxApiKey": config.get('MAPBOX_API_KEY'),
+            'features': features,
+            'mapboxApiKey': config.get('MAPBOX_API_KEY'),
         }
 
 
@@ -1778,8 +1778,8 @@ class DeckScatterViz(BaseDeckGLViz):
 
     """deck.gl's ScatterLayer"""
 
-    viz_type = "deck_scatter"
-    verbose_name = _("Deck.gl - Scatter plot")
+    viz_type = 'deck_scatter'
+    verbose_name = _('Deck.gl - Scatter plot')
 
     def query_obj(self):
         self.point_radius_fixed = self.form_data.get('point_radius_fixed')
@@ -1794,8 +1794,8 @@ class DeckScatterViz(BaseDeckGLViz):
 
     def get_properties(self, d):
         return {
-            "radius": self.fixed_value if self.fixed_value else d.get(self.metric),
-            "cat_color": d.get(self.dim) if self.dim else None,
+            'radius': self.fixed_value if self.fixed_value else d.get(self.metric),
+            'cat_color': d.get(self.dim) if self.dim else None,
         }
 
     def get_data(self, df):
@@ -1813,24 +1813,24 @@ class DeckScreengrid(BaseDeckGLViz):
 
     """deck.gl's ScreenGridLayer"""
 
-    viz_type = "deck_screengrid"
-    verbose_name = _("Deck.gl - Screen Grid")
+    viz_type = 'deck_screengrid'
+    verbose_name = _('Deck.gl - Screen Grid')
 
 
 class DeckGrid(BaseDeckGLViz):
 
     """deck.gl's DeckLayer"""
 
-    viz_type = "deck_grid"
-    verbose_name = _("Deck.gl - 3D Grid")
+    viz_type = 'deck_grid'
+    verbose_name = _('Deck.gl - 3D Grid')
 
 
 class DeckHex(BaseDeckGLViz):
 
     """deck.gl's DeckLayer"""
 
-    viz_type = "deck_hex"
-    verbose_name = _("Deck.gl - 3D HEX")
+    viz_type = 'deck_hex'
+    verbose_name = _('Deck.gl - 3D HEX')
 
 
 class EventFlowViz(BaseViz):

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <commits@superset.apache.org>'].

Mime
View raw message