superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grace...@apache.org
Subject [incubator-superset] branch master updated: Fixing an issue with stripping filter values (#3869)
Date Wed, 15 Nov 2017 03:22:06 GMT
This is an automated email from the ASF dual-hosted git repository.

graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new aee8438  Fixing an issue with stripping filter values (#3869)
aee8438 is described below

commit aee84389240c04ca2e369ab65a1b100f77327bb7
Author: michellethomas <michelle.q.thomas@gmail.com>
AuthorDate: Tue Nov 14 19:22:03 2017 -0800

    Fixing an issue with stripping filter values (#3869)
---
 superset/connectors/sqla/models.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py
index d7081d2..5c2be6f 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -465,7 +465,7 @@ class SqlaTable(Model, BaseDatasource):
                         # For backwards compatibility and edge cases
                         # where a column data type might have changed
                         if isinstance(v, basestring):
-                            v = v.strip(""").strip(""")
+                            v = v.strip("'").strip('"')
                             if col_obj.is_num:
                                 v = utils.string_to_num(v)
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <commits@superset.apache.org>'].

Mime
View raw message