superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grace...@apache.org
Subject [incubator-superset] branch master updated: [Dashboard bug]Fix userId prop in Explore view Save_Modal (#3857)
Date Tue, 14 Nov 2017 00:06:51 GMT
This is an automated email from the ASF dual-hosted git repository.

graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 3f076b0  [Dashboard bug]Fix userId prop in Explore view Save_Modal (#3857)
3f076b0 is described below

commit 3f076b00cde4bf9eb0ab1af01d437e933873494a
Author: Grace Guo <grace.guo@airbnb.com>
AuthorDate: Mon Nov 13 16:06:45 2017 -0800

    [Dashboard bug]Fix userId prop in Explore view Save_Modal (#3857)
    
    For userId, the attribute name in bootstrap data is user_id
---
 superset/assets/javascripts/explore/components/SaveModal.jsx           | 2 +-
 superset/assets/spec/javascripts/explore/components/SaveModal_spec.jsx | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/superset/assets/javascripts/explore/components/SaveModal.jsx b/superset/assets/javascripts/explore/components/SaveModal.jsx
index 7b375c2..2d716ae 100644
--- a/superset/assets/javascripts/explore/components/SaveModal.jsx
+++ b/superset/assets/javascripts/explore/components/SaveModal.jsx
@@ -243,7 +243,7 @@ function mapStateToProps({ explore, saveModal }) {
     datasource: explore.datasource,
     slice: explore.slice,
     can_overwrite: explore.can_overwrite,
-    userId: explore.userId,
+    userId: explore.user_id,
     dashboards: saveModal.dashboards,
     alert: saveModal.saveModalAlert,
   };
diff --git a/superset/assets/spec/javascripts/explore/components/SaveModal_spec.jsx b/superset/assets/spec/javascripts/explore/components/SaveModal_spec.jsx
index 346feda..e548d21 100644
--- a/superset/assets/spec/javascripts/explore/components/SaveModal_spec.jsx
+++ b/superset/assets/spec/javascripts/explore/components/SaveModal_spec.jsx
@@ -24,7 +24,7 @@ describe('SaveModal', () => {
     },
     explore: {
       can_overwrite: true,
-      userId: '1',
+      user_id: '1',
       datasource: {},
       slice: {
         slice_id: 1,

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <commits@superset.apache.org>'].

Mime
View raw message