superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: [flake8] Resolving F4?? errors (#3811)
Date Thu, 09 Nov 2017 04:34:35 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new d03b74f  [flake8] Resolving F4?? errors (#3811)
d03b74f is described below

commit d03b74f7540d02047b71c5784deeece274bb32ec
Author: John Bodley <4567245+john-bodley@users.noreply.github.com>
AuthorDate: Wed Nov 8 20:34:33 2017 -0800

    [flake8] Resolving F4?? errors (#3811)
---
 tests/celery_tests.py         | 1 -
 tests/druid_tests.py          | 7 +++----
 tests/superset_test_config.py | 1 +
 tests/viz_tests.py            | 3 ++-
 tox.ini                       | 3 ---
 5 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/tests/celery_tests.py b/tests/celery_tests.py
index 0debe66..b2681f2 100644
--- a/tests/celery_tests.py
+++ b/tests/celery_tests.py
@@ -14,7 +14,6 @@ import pandas as pd
 from past.builtins import basestring
 
 from superset import app, appbuilder, cli, dataframe, db
-from superset.models import core as models
 from superset.models.helpers import QueryStatus
 from superset.models.sql_lab import Query
 from superset.security import sync_role_definitions
diff --git a/tests/druid_tests.py b/tests/druid_tests.py
index 276a010..7ac3829 100644
--- a/tests/druid_tests.py
+++ b/tests/druid_tests.py
@@ -12,8 +12,7 @@ from mock import Mock, patch
 
 from superset import db, security, sm
 from superset.connectors.druid.models import (
-    DruidCluster, DruidDatasource, DruidMetric, Postaggregator, PyDruid,
-    Quantile,
+    DruidCluster, DruidDatasource, DruidMetric,
 )
 from .base_tests import SupersetTestCase
 
@@ -75,7 +74,7 @@ class DruidTests(SupersetTestCase):
     def __init__(self, *args, **kwargs):
         super(DruidTests, self).__init__(*args, **kwargs)
 
-    @patch('superset.connectors.druid.models.PyDruid')  # noqa ignore: F811
+    @patch('superset.connectors.druid.models.PyDruid')
     def test_client(self, PyDruid):
         self.login(username='admin')
         instance = PyDruid.return_value
@@ -280,7 +279,7 @@ class DruidTests(SupersetTestCase):
         self.assertIn('datasource_for_gamma', resp)
         self.assertNotIn('datasource_not_for_gamma', resp)
 
-    @patch('superset.connectors.druid.models.PyDruid')  # noqa ignore: F811
+    @patch('superset.connectors.druid.models.PyDruid')
     def test_sync_druid_perm(self, PyDruid):
         self.login(username='admin')
         instance = PyDruid.return_value
diff --git a/tests/superset_test_config.py b/tests/superset_test_config.py
index 6e6426d..d65c85f 100644
--- a/tests/superset_test_config.py
+++ b/tests/superset_test_config.py
@@ -1,3 +1,4 @@
+# flake8: noqa
 from superset.config import *
 
 AUTH_USER_REGISTRATION_ROLE = 'alpha'
diff --git a/tests/viz_tests.py b/tests/viz_tests.py
index 4b97027..416cf39 100644
--- a/tests/viz_tests.py
+++ b/tests/viz_tests.py
@@ -1,4 +1,4 @@
-from datetime import datetime, timedelta
+from datetime import datetime
 import unittest
 
 from mock import Mock, patch
@@ -8,6 +8,7 @@ import superset.utils as utils
 from superset.utils import DTTM_ALIAS
 import superset.viz as viz
 
+
 class BaseVizTestCase(unittest.TestCase):
     def test_constructor_exception_no_datasource(self):
         form_data = {}
diff --git a/tox.ini b/tox.ini
index a810a4a..66ddc80 100644
--- a/tox.ini
+++ b/tox.ini
@@ -37,9 +37,6 @@ ignore =
     E703
     E731
     E741
-    F401
-    F403
-    F405
     Q000
     Q001
 import-order-style = google

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <commits@superset.apache.org>'].

Mime
View raw message