Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0E796200D12 for ; Sat, 7 Oct 2017 22:07:32 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0CF451609DF; Sat, 7 Oct 2017 20:07:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5416C1609DA for ; Sat, 7 Oct 2017 22:07:31 +0200 (CEST) Received: (qmail 11116 invoked by uid 500); 7 Oct 2017 20:07:30 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 11107 invoked by uid 99); 7 Oct 2017 20:07:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Oct 2017 20:07:30 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 8B8D38126D; Sat, 7 Oct 2017 20:07:27 +0000 (UTC) Date: Sat, 07 Oct 2017 20:07:27 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: fixing date/time filter keys (#3611) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <150740684758.22878.11850747024455963681@gitbox.apache.org> From: maximebeauchemin@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 6f1351fbbb677b437c7754a05e48762ca4e5c57b X-Git-Newrev: 912c6f623159be69007cc9ee38b10e8adc7778ce X-Git-Rev: 912c6f623159be69007cc9ee38b10e8adc7778ce X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated archived-at: Sat, 07 Oct 2017 20:07:32 -0000 This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 912c6f6 fixing date/time filter keys (#3611) 912c6f6 is described below commit 912c6f623159be69007cc9ee38b10e8adc7778ce Author: Jeff Niu AuthorDate: Sat Oct 7 13:07:23 2017 -0700 fixing date/time filter keys (#3611) --- superset/assets/visualizations/filter_box.jsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/superset/assets/visualizations/filter_box.jsx b/superset/assets/visualizations/filter_box.jsx index 9605830..d09755a 100644 --- a/superset/assets/visualizations/filter_box.jsx +++ b/superset/assets/visualizations/filter_box.jsx @@ -149,7 +149,10 @@ class FilterBox extends React.Component { // Add created options to filtersChoices, even though it doesn't exist, // or these options will exist in query sql but invisible to end user. for (const filterKey in this.state.selectedValues) { - if (!this.state.selectedValues.hasOwnProperty(filterKey)) { + if ( + !this.state.selectedValues.hasOwnProperty(filterKey) || + !(filterKey in this.props.filtersChoices) + ) { continue; } const existValues = this.props.filtersChoices[filterKey].map(f => f.id); -- To stop receiving notification emails like this one, please contact ['"commits@superset.apache.org" '].