superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Using indexOf instead of includes for isXAxisString (#3733)
Date Fri, 27 Oct 2017 23:00:47 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 200b66d  Using indexOf instead of includes for isXAxisString (#3733)
200b66d is described below

commit 200b66d0883a39bb67ede50bf80a950e39c98022
Author: michellethomas <michelle.q.thomas@gmail.com>
AuthorDate: Fri Oct 27 16:00:44 2017 -0700

    Using indexOf instead of includes for isXAxisString (#3733)
---
 superset/assets/visualizations/nvd3_vis.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/assets/visualizations/nvd3_vis.js b/superset/assets/visualizations/nvd3_vis.js
index 69c7c64..bbef132 100644
--- a/superset/assets/visualizations/nvd3_vis.js
+++ b/superset/assets/visualizations/nvd3_vis.js
@@ -351,7 +351,7 @@ function nvd3Vis(slice, payload) {
       chart.x2Axis.tickFormat(xAxisFormatter);
       height += 30;
     }
-    const isXAxisString = ['dist_bar', 'box_plot'].includes(vizType) >= 0;
+    const isXAxisString = ['dist_bar', 'box_plot'].indexOf(vizType) >= 0;
     if (!isXAxisString && chart.xAxis && chart.xAxis.tickFormat) {
       chart.xAxis.tickFormat(xAxisFormatter);
     }

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <commits@superset.apache.org>'].

Mime
View raw message