superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: fixing date/time filter keys (#3611)
Date Sat, 07 Oct 2017 20:07:27 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 912c6f6  fixing date/time filter keys (#3611)
912c6f6 is described below

commit 912c6f623159be69007cc9ee38b10e8adc7778ce
Author: Jeff Niu <jeffniu22@gmail.com>
AuthorDate: Sat Oct 7 13:07:23 2017 -0700

    fixing date/time filter keys (#3611)
---
 superset/assets/visualizations/filter_box.jsx | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/superset/assets/visualizations/filter_box.jsx b/superset/assets/visualizations/filter_box.jsx
index 9605830..d09755a 100644
--- a/superset/assets/visualizations/filter_box.jsx
+++ b/superset/assets/visualizations/filter_box.jsx
@@ -149,7 +149,10 @@ class FilterBox extends React.Component {
     // Add created options to filtersChoices, even though it doesn't exist,
     // or these options will exist in query sql but invisible to end user.
     for (const filterKey in this.state.selectedValues) {
-      if (!this.state.selectedValues.hasOwnProperty(filterKey)) {
+      if (
+        !this.state.selectedValues.hasOwnProperty(filterKey) ||
+        !(filterKey in this.props.filtersChoices)
+      ) {
         continue;
       }
       const existValues = this.props.filtersChoices[filterKey].map(f => f.id);

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <commits@superset.apache.org>'].

Mime
View raw message