superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Allow users to see query string when query returns no data (#3585)
Date Wed, 04 Oct 2017 05:32:19 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 40fbf1c  Allow users to see query string when query returns no data (#3585)
40fbf1c is described below

commit 40fbf1c761decb9773ca0380d6d4f383f9348ea1
Author: Jeff Niu <jeffniu22@gmail.com>
AuthorDate: Tue Oct 3 22:32:17 2017 -0700

    Allow users to see query string when query returns no data (#3585)
---
 .../assets/javascripts/explore/components/DisplayQueryButton.jsx     | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/superset/assets/javascripts/explore/components/DisplayQueryButton.jsx b/superset/assets/javascripts/explore/components/DisplayQueryButton.jsx
index da578cd..ec5cdcd 100644
--- a/superset/assets/javascripts/explore/components/DisplayQueryButton.jsx
+++ b/superset/assets/javascripts/explore/components/DisplayQueryButton.jsx
@@ -65,7 +65,10 @@ export default class DisplayQueryButton extends React.PureComponent {
     });
   }
   beforeOpen() {
-    if (['loading', null].indexOf(this.props.chartStatus) >= 0 || !this.props.queryResponse)
{
+    if (
+      ['loading', null].indexOf(this.props.chartStatus) >= 0
+      || !this.props.queryResponse || !this.props.queryResponse.query
+    ) {
       this.fetchQuery();
     } else {
       this.setStateFromQueryResponse();

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <commits@superset.apache.org>'].

Mime
View raw message