superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Getting datatype with its dialect (#3486)
Date Mon, 18 Sep 2017 16:55:43 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 6fe93e1  Getting datatype with its dialect (#3486)
6fe93e1 is described below

commit 6fe93e18c79eeab470f0297014ad9453552e31aa
Author: datinho <lorenzo.bagni@gmail.com>
AuthorDate: Mon Sep 18 18:55:41 2017 +0200

    Getting datatype with its dialect (#3486)
---
 superset/connectors/sqla/models.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py
index 245da8a..1ffae85 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -598,7 +598,7 @@ class SqlaTable(Model, BaseDatasource):
         db_dialect = self.database.get_sqla_engine().dialect
         for col in table.columns:
             try:
-                datatype = "{}".format(col.type).upper()
+                datatype = "{}".format(col.type.compile(dialect=db_dialect)).upper()
             except Exception as e:
                 datatype = "UNKNOWN"
                 logging.error(

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <commits@superset.apache.org>'].

Mime
View raw message