superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: fix https://github.com/apache/incubator-superset/issues/3430 (#3431)
Date Tue, 12 Sep 2017 19:06:40 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 8223729  fix https://github.com/apache/incubator-superset/issues/3430 (#3431)
8223729 is described below

commit 8223729e1ebee9fa0a1116c736037f750e8b2578
Author: Grace Guo <grace.guo@airbnb.com>
AuthorDate: Tue Sep 12 12:06:38 2017 -0700

    fix https://github.com/apache/incubator-superset/issues/3430 (#3431)
---
 .../javascripts/SqlLab/components/QuerySearch.jsx   | 15 +++++++--------
 superset/assets/javascripts/SqlLab/main.less        |  7 +++++++
 superset/assets/javascripts/explore/main.css        |  4 ++++
 superset/assets/stylesheets/superset.less           | 21 +++++++++++++++------
 4 files changed, 33 insertions(+), 14 deletions(-)

diff --git a/superset/assets/javascripts/SqlLab/components/QuerySearch.jsx b/superset/assets/javascripts/SqlLab/components/QuerySearch.jsx
index 44daa39..5101f09 100644
--- a/superset/assets/javascripts/SqlLab/components/QuerySearch.jsx
+++ b/superset/assets/javascripts/SqlLab/components/QuerySearch.jsx
@@ -153,7 +153,7 @@ class QuerySearch extends React.PureComponent {
               placeholder="Search Results"
             />
           </div>
-          <div className="col-sm-1">
+          <div className="col-sm-4 search-date-filter-container">
             <Select
               name="select-from"
               placeholder="[From]-"
@@ -163,8 +163,7 @@ class QuerySearch extends React.PureComponent {
               autosize={false}
               onChange={this.changeFrom.bind(this)}
             />
-          </div>
-          <div className="col-sm-1">
+
             <Select
               name="select-to"
               placeholder="[To]-"
@@ -173,8 +172,7 @@ class QuerySearch extends React.PureComponent {
               autosize={false}
               onChange={this.changeTo.bind(this)}
             />
-          </div>
-          <div className="col-sm-1">
+
             <Select
               name="select-status"
               placeholder="[Query Status]"
@@ -184,10 +182,11 @@ class QuerySearch extends React.PureComponent {
               autosize={false}
               onChange={this.changeStatus.bind(this)}
             />
+
+            <Button bsSize="small" bsStyle="success" onClick={this.refreshQueries.bind(this)}>
+              Search
+            </Button>
           </div>
-          <Button bsSize="small" bsStyle="success" onClick={this.refreshQueries.bind(this)}>
-            Search
-          </Button>
         </div>
         {this.state.queriesLoading ?
           (<img className="loading" alt="Loading..." src="/static/assets/images/loading.gif"
/>)
diff --git a/superset/assets/javascripts/SqlLab/main.less b/superset/assets/javascripts/SqlLab/main.less
index 577c8ab..f11329c 100644
--- a/superset/assets/javascripts/SqlLab/main.less
+++ b/superset/assets/javascripts/SqlLab/main.less
@@ -292,3 +292,10 @@ a.Link {
 .SouthPane {
     margin-top: 10px;
 }
+.search-date-filter-container {
+    display: flex;
+
+    .Select {
+        margin-right: 3px;
+    }
+}
diff --git a/superset/assets/javascripts/explore/main.css b/superset/assets/javascripts/explore/main.css
index 845b0b5..abae1ce 100644
--- a/superset/assets/javascripts/explore/main.css
+++ b/superset/assets/javascripts/explore/main.css
@@ -32,6 +32,10 @@
   box-shadow: none;
 }
 
+.control-panel-section .Select-multi-value-wrapper .Select-input > input {
+  width: 100px;
+}
+
 .background-transparent {
   background-color: transparent !important;
 }
diff --git a/superset/assets/stylesheets/superset.less b/superset/assets/stylesheets/superset.less
index 6dca610..b0a4ed5 100644
--- a/superset/assets/stylesheets/superset.less
+++ b/superset/assets/stylesheets/superset.less
@@ -340,13 +340,22 @@ iframe {
 }
 
 // overwrite react-select css
-.Select-multi-value-wrapper .Select-input {
-  display: inline-block;
-  width: 100px;
-}
-.Select--multi .Select-value {
-  line-height: 1.2;
+.Select--multi {
+  .Select-multi-value-wrapper {
+    display: flex;
+    flex-wrap: wrap;
+    padding-bottom: 3px;
+  }
+
+  .Select-value {
+    line-height: 1.2;
+  }
+
+  .Select-input > input {
+    width: 100px;
+  }
 }
+
 .dimmed {
   opacity: 0.5;
 }

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <commits@superset.apache.org>'].

Mime
View raw message