Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 48707200CF2 for ; Sat, 19 Aug 2017 02:43:17 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 46F8316DB1E; Sat, 19 Aug 2017 00:43:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8E5DE16DB1D for ; Sat, 19 Aug 2017 02:43:16 +0200 (CEST) Received: (qmail 65530 invoked by uid 500); 19 Aug 2017 00:43:15 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 65521 invoked by uid 99); 19 Aug 2017 00:43:15 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Aug 2017 00:43:15 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 67C64811E0; Sat, 19 Aug 2017 00:43:13 +0000 (UTC) Date: Sat, 19 Aug 2017 00:43:13 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: [hotfix] self-immune filter_box fix (#3338) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <150310339379.4425.2753416468560086587@gitbox.apache.org> From: maximebeauchemin@apache.org Reply-To: "commits@superset.apache.org" X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 75e69f02e8bb701f22390f42a43ed1931e951b90 X-Git-Newrev: e79adbbc5f6e44a7cacac06f8b9d8edab3098be5 X-Git-Rev: e79adbbc5f6e44a7cacac06f8b9d8edab3098be5 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated archived-at: Sat, 19 Aug 2017 00:43:17 -0000 This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new e79adbb [hotfix] self-immune filter_box fix (#3338) e79adbb is described below commit e79adbbc5f6e44a7cacac06f8b9d8edab3098be5 Author: Maxime Beauchemin AuthorDate: Fri Aug 18 17:43:11 2017 -0700 [hotfix] self-immune filter_box fix (#3338) --- superset/assets/javascripts/dashboard/Dashboard.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset/assets/javascripts/dashboard/Dashboard.jsx b/superset/assets/javascripts/dashboard/Dashboard.jsx index 39eab0e..8a7000e 100644 --- a/superset/assets/javascripts/dashboard/Dashboard.jsx +++ b/superset/assets/javascripts/dashboard/Dashboard.jsx @@ -188,7 +188,7 @@ export function dashboardContainer(dashboard, datasources, userid) { immuneToFields = this.metadata.filter_immune_slice_fields[sliceId]; } for (const filteringSliceId in this.filters) { - if (filteringSliceId === sliceId) { + if (filteringSliceId === sliceId.toString()) { // Filters applied by the slice don't apply to itself continue; } -- To stop receiving notification emails like this one, please contact ['"commits@superset.apache.org" '].