Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4DD52200CDA for ; Fri, 4 Aug 2017 18:05:56 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4BDEB16DCB2; Fri, 4 Aug 2017 16:05:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 97A2316DCB0 for ; Fri, 4 Aug 2017 18:05:55 +0200 (CEST) Received: (qmail 63814 invoked by uid 500); 4 Aug 2017 16:05:54 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 63800 invoked by uid 99); 4 Aug 2017 16:05:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Aug 2017 16:05:54 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 82A1E875F7; Fri, 4 Aug 2017 16:05:52 +0000 (UTC) Date: Fri, 04 Aug 2017 16:05:52 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: [bug fix] Fix to #3137 and #3239 (#3240) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <150186275267.18849.5247263905315464295@gitbox.apache.org> From: maximebeauchemin@apache.org Reply-To: "commits@superset.apache.org" X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 0191fa58c87c878147ce3e6d4645c587dcd268e8 X-Git-Newrev: 2ef9bfed2057144e33cf36c9447337742bab677f X-Git-Rev: 2ef9bfed2057144e33cf36c9447337742bab677f X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated archived-at: Fri, 04 Aug 2017 16:05:56 -0000 This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 2ef9bfe [bug fix] Fix to #3137 and #3239 (#3240) 2ef9bfe is described below commit 2ef9bfed2057144e33cf36c9447337742bab677f Author: Shao-Yen "Fred" Cheng AuthorDate: Fri Aug 4 09:05:50 2017 -0700 [bug fix] Fix to #3137 and #3239 (#3240) * #3137 add the leftover code from #3138 for fixing issue #3137 * #3239 Use slice id as the key instead of sliceName --- superset/assets/javascripts/dashboard/components/SliceAdder.jsx | 7 ++++++- .../javascripts/explore/components/ControlPanelsContainer.jsx | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/superset/assets/javascripts/dashboard/components/SliceAdder.jsx b/superset/assets/javascripts/dashboard/components/SliceAdder.jsx index a96effe..cb92066 100644 --- a/superset/assets/javascripts/dashboard/components/SliceAdder.jsx +++ b/superset/assets/javascripts/dashboard/components/SliceAdder.jsx @@ -129,9 +129,14 @@ class SliceAdder extends React.Component { height="auto" >