superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: [hotfix] self-immune filter_box fix (#3338)
Date Sat, 19 Aug 2017 00:43:13 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new e79adbb  [hotfix] self-immune filter_box fix (#3338)
e79adbb is described below

commit e79adbbc5f6e44a7cacac06f8b9d8edab3098be5
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Fri Aug 18 17:43:11 2017 -0700

    [hotfix] self-immune filter_box fix (#3338)
---
 superset/assets/javascripts/dashboard/Dashboard.jsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/assets/javascripts/dashboard/Dashboard.jsx b/superset/assets/javascripts/dashboard/Dashboard.jsx
index 39eab0e..8a7000e 100644
--- a/superset/assets/javascripts/dashboard/Dashboard.jsx
+++ b/superset/assets/javascripts/dashboard/Dashboard.jsx
@@ -188,7 +188,7 @@ export function dashboardContainer(dashboard, datasources, userid) {
         immuneToFields = this.metadata.filter_immune_slice_fields[sliceId];
       }
       for (const filteringSliceId in this.filters) {
-        if (filteringSliceId === sliceId) {
+        if (filteringSliceId === sliceId.toString()) {
           // Filters applied by the slice don't apply to itself
           continue;
         }

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <commits@superset.apache.org>'].

Mime
View raw message