superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Unnecessary to specify order_columns for DatasourceModelView (#3331)
Date Fri, 18 Aug 2017 05:18:35 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 813ed60  Unnecessary to specify order_columns for DatasourceModelView (#3331)
813ed60 is described below

commit 813ed6018d4e4a6886a27e01b7d31dc422185a8d
Author: Rogan <quangenw@gmail.com>
AuthorDate: Fri Aug 18 13:18:32 2017 +0800

    Unnecessary to specify order_columns for DatasourceModelView (#3331)
---
 superset/connectors/druid/views.py | 2 --
 superset/connectors/sqla/views.py  | 2 --
 2 files changed, 4 deletions(-)

diff --git a/superset/connectors/druid/views.py b/superset/connectors/druid/views.py
index b85e611..a06bc39 100644
--- a/superset/connectors/druid/views.py
+++ b/superset/connectors/druid/views.py
@@ -178,8 +178,6 @@ class DruidDatasourceModelView(DatasourceModelView, DeleteMixin):  # noqa
     list_widget = ListWidgetWithCheckboxes
     list_columns = [
         'datasource_link', 'cluster', 'changed_by_', 'modified']
-    order_columns = [
-        'datasource_link', 'changed_on_', 'offset']
     related_views = [DruidColumnInlineView, DruidMetricInlineView]
     edit_columns = [
         'datasource_name', 'cluster', 'slices', 'description', 'owner',
diff --git a/superset/connectors/sqla/views.py b/superset/connectors/sqla/views.py
index 21529b1..c49d4d0 100644
--- a/superset/connectors/sqla/views.py
+++ b/superset/connectors/sqla/views.py
@@ -160,8 +160,6 @@ class TableModelView(DatasourceModelView, DeleteMixin):  # noqa
     list_columns = [
         'link', 'database',
         'changed_by_', 'modified']
-    order_columns = [
-        'link', 'database', 'changed_on_']
     add_columns = ['database', 'schema', 'table_name']
     edit_columns = [
         'table_name', 'sql', 'filter_select_enabled', 'slices',

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <commits@superset.apache.org>'].

Mime
View raw message