superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: disable immediately re-render for color scheme change (#3328)
Date Fri, 18 Aug 2017 04:38:36 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 0454ef3  disable immediately re-render for color scheme change (#3328)
0454ef3 is described below

commit 0454ef3726fc638da3b9e3323cef3381ff0a01d1
Author: Grace Guo <grace.guo@airbnb.com>
AuthorDate: Thu Aug 17 21:38:34 2017 -0700

    disable immediately re-render for color scheme change (#3328)
    
    for chart type: bubble, area, treemap and country map, color scheme change cannot take
effect immediately. So have to disable immediately re-render function and hide lightening
icon for these chart type.
---
 superset/assets/javascripts/explore/stores/visTypes.js | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/superset/assets/javascripts/explore/stores/visTypes.js b/superset/assets/javascripts/explore/stores/visTypes.js
index 81496fa..56c7fea 100644
--- a/superset/assets/javascripts/explore/stores/visTypes.js
+++ b/superset/assets/javascripts/explore/stores/visTypes.js
@@ -292,6 +292,9 @@ export const visTypes = {
         default: 'smart_date',
         choices: D3_TIME_FORMAT_OPTIONS,
       },
+      color_scheme: {
+        renderTrigger: false,
+      },
     },
   },
 
@@ -421,6 +424,11 @@ export const visTypes = {
         ],
       },
     ],
+    controlOverrides: {
+      color_scheme: {
+        renderTrigger: false,
+      },
+    },
   },
 
   cal_heatmap: {
@@ -500,6 +508,9 @@ export const visTypes = {
       x_axis_format: {
         default: '.3s',
       },
+      color_scheme: {
+        renderTrigger: false,
+      },
     },
   },
 
@@ -720,6 +731,9 @@ export const visTypes = {
         label: 'Metric',
         description: 'Metric to display bottom title',
       },
+      linear_color_scheme: {
+        renderTrigger: false,
+      },
     },
   },
   world_map: {

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <commits@superset.apache.org>'].

Mime
View raw message