superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Fix styles in Separator widget (#3309)
Date Thu, 17 Aug 2017 00:40:08 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new fbd0d46  Fix styles in Separator widget (#3309)
fbd0d46 is described below

commit fbd0d46e8ab8e2928a5e5971679c3a2def98ed87
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Wed Aug 16 17:40:06 2017 -0700

    Fix styles in Separator widget (#3309)
    
    Style wasn't working right for separator widget since the iframe sandboxing of
    the markup widget. This addresses this small issue and also now allows
    for html in the separator widget
---
 superset/assets/javascripts/explore/stores/visTypes.js | 1 +
 superset/viz.py                                        | 4 ----
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/superset/assets/javascripts/explore/stores/visTypes.js b/superset/assets/javascripts/explore/stores/visTypes.js
index e937b03..7e04237 100644
--- a/superset/assets/javascripts/explore/stores/visTypes.js
+++ b/superset/assets/javascripts/explore/stores/visTypes.js
@@ -358,6 +358,7 @@ export const visTypes = {
       {
         label: null,
         controlSetRows: [
+          ['markup_type'],
           ['code'],
         ],
       },
diff --git a/superset/viz.py b/superset/viz.py
index 100d8bb..98f2d1b 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -449,10 +449,6 @@ class SeparatorViz(MarkupViz):
     viz_type = "separator"
     verbose_name = _("Separator")
 
-    def get_data(self, df):
-        code = markdown(self.form_data.get("code", ''))
-        return dict(html=code)
-
 
 class WordCloudViz(BaseViz):
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <commits@superset.apache.org>'].

Mime
View raw message