Mailing-List: contact users-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: local policy)
Date: Fri, 15 Jun 2012 21:42:35 +0300
From: Daniel Shahaf <danielsh@elego.de>
To: Johan Corveleyn <jcorvel@gmail.com>
Cc: Vladimir Shun'kov <shunya.v@gmail.com>,
	"Cooke, Mark" <mark.cooke@siemens.com>,
	Andy Levy <andy.levy@gmail.com>,
	"users@subversion.apache.org" <users@subversion.apache.org>
Subject: Re: Commit size
Message-ID: <20120615184235.GK3526@lp-shahaf.local>
References: 
 <CAH-AShGen1CvD5pKfua4kSNPLyEQdryS2Eo5Bsts5dOOcRVeqg@mail.gmail.com>
 <CALb=wnnWq0L86viOZ+nDF_gOq4JK0QqptO=1P2EB2ooSrLTaVQ@mail.gmail.com>
 <CAH-AShHf3tThmakDeA9n4+OZJqk49P=cR41bL8DAWQ2sYWbgtg@mail.gmail.com>
 <CALb=wnkNgQELCxosoY4p8VQfby1H=_Ks8sYorzDGE53xpJrqMA@mail.gmail.com>
 <4F7A7621A511B945915EB16D655311D8126D10BDF7@GBOXFW99E01MSX.ww005.siemens.net>
 <CAH-AShHjS+AjAPH4rFp7NSGw9LBGNJWct0LEFveJPsXA9ym7+g@mail.gmail.com>
 <CAB84uBXQcX_h_03LwRSToZmJ4HBV1q3kVU2c23BYBWiE9iHMMg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAB84uBXQcX_h_03LwRSToZmJ4HBV1q3kVU2c23BYBWiE9iHMMg@mail.gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)

Johan Corveleyn wrote on Wed, Jun 13, 2012 at 15:32:56 +0200:
> On Wed, Jun 13, 2012 at 3:16 PM, Vladimir Shun'kov <shunya.v@gmail.com> wrote:
> > Would be enough have the number bytes of changes. I did disk usage in
> > pre-commit hook and disk usage in post-commit hook and then calculated
> > the difference. But I commited the new file with size 20Kb and size of
> > commit I recieved only 5Kb due some svn compression I guess.
> 
> In 1.7, there's a new svnlook subcommand: 'svnlook filesize'. This can
> give you the filesize of any file (from a revision or a transaction),
> without having to 'svnlook cat' it (i.e. more efficiently).
> 
> Maybe you can use that directly, or use it to calculate the difference?
> 
> Like, in the pre-commit hook:
> 
> 1) 'svnlook changed -t $TXN $REPOS' to get the list of changes in this
> transaction
> 
> 2) For every changed (or added) file, do 'svnlook filesize -t $TXN $REPOS'
> 
> 3) For changed files, compare them to 'svnlook filesize -r $YOUNGEST
> $REPOS' where $YOUNGEST is the result of 'svnlook youngest $REPOS'.
> 
> 4) Do some arithmetic on the result
> 

$TXN may be based on a revision earlier than $YOUNGEST, and the file may
have changed between that base revision and youngest.  If that happens,
the commit attempt will fail due to a conflict, but before that happens
the logic above would make calculations based on the wrong information.

I don't know if there is an svnlook API to print the base revision of
a given txn... but I guess there should be.

> HTH
> -- 
> Johan