subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Johan Corveleyn <jcor...@gmail.com>
Subject Re: Python3 work [was: The run up to Subversion 1.13.0]
Date Fri, 27 Sep 2019 20:51:04 GMT
On Fri, Sep 27, 2019 at 8:14 PM Yasuhito FUTATSUKI <futatuki@poem.co.jp> wrote:
> Thank you for testing.

And thank you for hanging in there for the py3 work :-).

> It seems that urllib.request.pathname2url() on Windows doesn't accept
> bytes on Python 3, while on Linux/Unix it accepts both of bytes and str.
>
> The patch attached may fix it.

Great! That fixes this particular problem, and the test suite now runs
successfully ... almost. There seems to be one more problem:

[[[
Testing Release configuration on local repository.
-- Running Swig Python tests --
..........................................................C:\Python37\lib\subprocess.py:858:
ResourceWarning: subprocess
 8548 is still running
  ResourceWarning, source=self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
C:\Python37\lib\unittest\case.py:628: ResourceWarning: unclosed file
<_io.BufferedReader name=3>
  testMethod()
ResourceWarning: Enable tracemalloc to get the object allocation traceback
.C:\Python37\lib\unittest\case.py:628: ResourceWarning: unclosed file
<_io.BufferedReader name='R:\\temp\\tmpryeb61g1'>
  testMethod()
ResourceWarning: Enable tracemalloc to get the object allocation traceback
..............................................................................................
----------------------------------------------------------------------
Ran 153 tests in 66.182s

OK
]]]

> > (The warning about 'ruby' is not a big deal I suppose, but it's also
> > something I saw when running gen-make.py with python 3.7 -- not when
> > I'm running it with python 2.7)
>
> I think that message comes from build/generator/gen_win_dependencies.py,
> GenDependenciesBase._find_ruby() line 967 (message from shell program
> on Windows).
>
> https://svn.apache.org/viewvc/subversion/branches/swig-py3/build/generator/gen_win_dependencies.py?revision=1862754&view=markup#l967
>
> This may be also caused with Python 2, if 'ruby' is not in command
> search path.

Thanks. I'll try to take a closer look, but it's not a priority. It's
still a bit strange to me that Python 2 doesn't show this warning
while Python 3 does (environment is the same, PATH is the same, except
for Python itself).

-- 
Johan

Mime
View raw message