subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Sperling <s...@apache.org>
Subject Re: svn commit: r1850651 - /subversion/trunk/subversion/mod_dav_svn/repos.c
Date Thu, 15 Aug 2019 17:25:05 GMT
On Thu, Aug 15, 2019 at 08:14:43PM +0300, Sergey Raevskiy wrote:
> >   /* if an authenticated username is present, attach it to the FS */
> >    if (r->user)
> > @@ -2503,6 +2529,14 @@ get_resource(request_rec *r,
> >        apr_pool_cleanup_register(r->pool, cleanup_baton, cleanup_fs_access,
> >                                  apr_pool_cleanup_null);
> >
> > +      /* We must degrade the logging context when the request is freed. */
> > +      cleanup_req_logging_baton =
> > +        apr_pcalloc(r->pool, sizeof(*cleanup_req_logging_baton));
> > +      cleanup_req_logging_baton->fs = repos->fs;
> > +      cleanup_req_logging_baton->connection = r->connection;
> > +      apr_pool_pre_cleanup_register(r->pool, cleanup_req_logging_baton,
> > +                                    cleanup_req_logging);
> 
> Is it intended to set-up this cleanup handler only if R->USER is specified?

Thanks Sergey!

Good question. Looking back at this patch, this looks like an accident.

Were you planning on writing a fix?

Mime
View raw message