subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yasuhito FUTATSUKI <futat...@yf.bsdclub.org>
Subject Re: [PATCH]On branch swig-py3: accept both of bytes/str for inputchar * args
Date Sun, 17 Feb 2019 06:10:07 GMT
On 2/17/19 9:04 AM, Daniel Shahaf wrote:

> I was wondering what are the blockers for merging swig-py3 into trunk?
> The only item in BRANCH-README is "Fix a compile error on windows with
> py3", but I don't even know if that's a current issue or an old one that has
> since been fixed.

I'm sorry I'm not sure the compile error still exists or not. (I don't
have Windows build environment yet)

The only thing I know about it, my patch committed on r1849784 might break
Windows build because of "PY3" macro for swig which added only Unix/Linux
build. However, it might not be a compile error, but might produce improper
codes under py3 environment, and this might be dissolved on r1853592,
for "PY3" macro in swig typemaps no longer used.


I think there are still some other points need to look over.

* Do scrpts under tools/ work on py3?
* If we want to install py2 bindings and py3 bindings at the same time,
   we must rename libsvn_swig_py library for py3.

Cheers,
-- 
Yasuhito FUTATSUKI



Mime
View raw message