subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: svn commit: r1848393 - in /subversion/site: publish/.message-ids.tsv tools/haxx-url-to-message-id.sh
Date Tue, 11 Dec 2018 10:25:11 GMT
Julian Foad wrote on Tue, Dec 11, 2018 at 10:08:29 +0000:
> Added '-q'etc.
> 

Thanks.

> I also made it:
>   * not commit if the only change is in the the "# Generated ... <date>" line.
>   * search only in the "publish" subtree, so it doesn't pick up the example in its own
script

I don't think it will pick up the example in its own source, because the
regexp therein doesn't match itself.  (That is, «lambda s: re.search(s, s)»
would return None for the 'https?://…' regex)

>   * the 'curl | perl' part of the script wants a way to fail if the 'curl' fails (Bash
has 'set -o pipefail' for this).

We could use a tmpfile, or target bash explicitly (in the #! line too),
or simplify the Perl so it dies if it gets no input (as implemented it's
a "do a transformation for every line" loop, and zero lines aren't an
error)…

Mime
View raw message