From dev-return-38575-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Thu Nov 22 02:11:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 51C68180668 for ; Thu, 22 Nov 2018 02:11:05 +0100 (CET) Received: (qmail 58145 invoked by uid 500); 22 Nov 2018 01:11:04 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 58135 invoked by uid 99); 22 Nov 2018 01:11:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Nov 2018 01:11:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 24D60C0467 for ; Thu, 22 Nov 2018 01:11:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.801 X-Spam-Level: X-Spam-Status: No, score=-0.801 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=daniel.shahaf.name header.b=Y8V3gnfX; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=mkzX4PQA Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id o1s8ewqXHMpY for ; Thu, 22 Nov 2018 01:11:01 +0000 (UTC) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 04C5F5FB11 for ; Thu, 22 Nov 2018 01:11:00 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C7172221ED for ; Wed, 21 Nov 2018 20:11:00 -0500 (EST) Received: from web2 ([10.202.2.212]) by compute3.internal (MEProxy); Wed, 21 Nov 2018 20:11:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=message-id:from:to:mime-version :content-transfer-encoding:content-type:date:subject:references :in-reply-to; s=fm1; bh=XTGTRYG4M7VTU8F8e50mywp5GtpNMvZdW9T2hdXI Pro=; b=Y8V3gnfXbTePjYoYjjT66PsB1w1f1qpNf7snoxaPKoQjND33f+hc7FNg 6xXgmtMukDAslFMUll5Puzug7fbj6i+j1uT6ReiiOslca7hiYyamE9eh1o5k7gJg NjR6wQ19psQsOUNoC+NhAXoXhiuZSk60QmvcWerxPy8CNN0aaj7PZ18p486K3XzL 9wqXT4hMmuedvSf+I+47cLNjN9fQaAyJMQvG7vbvLBEb46/SaqGEQzSsGjLGp6i+ 1XPwylN7h1vTC/T9hGR3cwz2m+9POxlu5LhbUMfJ7Ai+1SqKrDefss1T8dwgzuf+ Az6Mu4GWD0NTwLGA5oASKljpBhRwRw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=XTGTRYG4M7VTU8F8e50mywp5GtpNMvZdW9T2hdXIP ro=; b=mkzX4PQAzgwQiz/MiiklQkW02m5wD4nDajMInlxIYQ/aVHsbj3dpvbNWS QWlvnBHqzWspIb9VXt/03nikbYtmNvyPE4JlECLYuAJq35hHgobnfXzNTxhmm34+ InC+pf8ZxziIwp6ioSoagSrhEcTLfEs7iR48/zPKi5DvPoVZoxBbRFrpV6piB9ul QBr5ZRm0fG9ymRjWjjRJe1ku2uTQnYZ5XqHeSQV1QbkHbC3DGolMXkFuea4+tzLW 7+ufNVH7sXALkDE8fs5xcvf7cEo/lXrKn4kV76vxBkvID3xg/DTOlZkBrBxW3Xkl S5lujf2sWPcZ3UHb/MpCYQZ8JVQAA== X-ME-Sender: X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 47F38622C6; Wed, 21 Nov 2018 20:11:00 -0500 (EST) Message-Id: <1542849060.1966150.1585137680.531132A6@webmail.messagingengine.com> From: Daniel Shahaf To: dev@subversion.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-3449945b Date: Thu, 22 Nov 2018 01:11:00 +0000 Subject: Re: [PATCH] Re: [PATCH] A test for "Can't get entries" error References: <55095032.ozZm5OQrnM@dmit10> <20181120072905.u6pc5pzphp2cz4so@tarpaulin.shahaf.local2> <1542703110.1751358.1582899104.3801B128@webmail.messagingengine.com> <1542706099.3133757.1582952768.6221A4B5@webmail.messagingengine.com> <20181121145523.kgwfhlrhiffm5ru7@tarpaulin.shahaf.local2> <1542816018.3058106.1584613232.4FC1048B@webmail.messagingengine.com> <1542847897.1962451.1585113992.4B182350@webmail.messagingengine.com> In-Reply-To: <1542847897.1962451.1585113992.4B182350@webmail.messagingengine.com> Daniel Shahaf wrote on Thu, 22 Nov 2018 00:51 +0000: > While we're at this function, does anyone understand why directory[1] is > accessed without checking whether directory[0] is not NUL? There is > a comment there, but it doesn't enlighten me. (However, I haven't run > 'blame' on that comment yet.) Even if it's correct, is there any reason > not to add an SVN_ERR_ASSERT(directory[0]) there? Sorry, that's not quite the issue. directory[0] is almost certainly '/', and that's a fundamental enough aspect of canonical paths that we shouldn't need to assert it everywhere; but I'm still not certain what . /* root nodes are covered anyway */ . means. Cheers, Daniel