From dev-return-38572-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Thu Nov 22 00:05:22 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C0582180668 for ; Thu, 22 Nov 2018 00:05:21 +0100 (CET) Received: (qmail 57272 invoked by uid 500); 21 Nov 2018 23:05:20 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 57256 invoked by uid 99); 21 Nov 2018 23:05:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Nov 2018 23:05:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B6A84C0827 for ; Wed, 21 Nov 2018 23:05:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.002 X-Spam-Level: X-Spam-Status: No, score=-0.002 tagged_above=-999 required=6.31 tests=[SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id g-VRPQQWNmZb for ; Wed, 21 Nov 2018 23:05:16 +0000 (UTC) Received: from poem.co.jp (sv.poem.co.jp [124.35.235.17]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id BDB485F52B for ; Wed, 21 Nov 2018 23:05:15 +0000 (UTC) Received: from leopardon-alpha.yf.bsdclub.org (FL1-133-203-93-81.iba.mesh.ad.jp [133.203.93.81]) (authenticated bits=0) by poem.co.jp (8.13.8/8.13.8) with ESMTP id wALE5526009634 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Wed, 21 Nov 2018 23:05:05 +0900 Subject: Re: [swig-py3][patch] interfacing bytes object instead of str From: Yasuhito FUTATSUKI To: dev@subversion.apache.org Cc: futatuki@yf.bsdclub.org References: Message-ID: <032a4916-fb6d-1338-5919-27af0bb7ebea@poem.co.jp> Date: Thu, 22 Nov 2018 08:05:44 +0900 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-2022-jp; format=flowed; delsp=yes Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/22/18 3:22 AM, Yasuhito FUTATSUKI wrote: > Here is a patch against typemap file core.i, try to change > svn_stream_read*() and svn_stream_write() interface to use > bytes object. Even with this patch, svn_stream_readline() doesn't work well. It claims 2nd argment is not bytes object, and returns str object. I think it is better that svn_stream_readlin() returns bytes too. I'll try to fix, though I'm not sure I can. -- Yasuhito FUTATSUKI