subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <br...@apache.org>
Subject Re: [PATCH] Coredump when javahl SVNClient::diff() called with diff-cmd set
Date Thu, 01 Nov 2018 08:40:37 GMT
On 29.10.2018 16:36, matthew.burt@nats.co.uk wrote:
> Prevent some coredumps when using JavaHL SVNClient::diff()
>
> SVNClient::diff() discards output to stderr by setting stderr parameters to NULL in some
calls
>
> Some of the called code can dereference the NULL in some situations. One
> such situation is if the user has set a diff-cmd value in their settings file.
>
> The documented interface to relevant routines does not say that stderr can be set to
NULL in this way.
>
> Observed in the 1.10.3 client
>
> * subversion/bindings/javahl/native/SVNClient.cpp
>
>   (SVNClient::diff): Replace NULL stderr in calls to (deprecated) svn_client_diff_peg6()
>    and svn_client_diff6() with svn_stream_empty objects.

Thanks, committed in r1845408, and I'll propose this for backports to
1.10.x and 1.11.x.

-- Brane


Mime
View raw message