subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko Čibej <br...@apache.org>
Subject Re: truncated author names in 'svn ls -v' output
Date Sun, 25 Nov 2018 17:51:51 GMT
On 25.11.2018 10:53, Stefan Sperling wrote:
> On Sun, Nov 25, 2018 at 06:06:20AM +0100, Branko Čibej wrote:
>> On 23.11.2018 18:47, Branko Čibej wrote:
>>> On 23.11.2018 10:40, Daniel Shahaf wrote:
>>>> Branko Čibej wrote on Fri, 23 Nov 2018 10:15 +0100:
>>>>> On 23.11.2018 09:10, Stefan Sperling wrote:
>>>>>> I would like make a change, but it is a highly bikesheddy one so
>>>>>> I'd rather ask the list first to give everyone a chance to suggest
>>>>>> their favourite colours.
>>>>>>
>>>>>> The length of author names in 'svn ls -v' output is currently truncated
>>>>>> at 8 columns. Things have been this way since the dawn of time:
>>>>>> https://svn.apache.org/r842817
>>>>> So it has, the idea was to make the output easily parseable with 'cut'
>>>>> etc. That was long before --xml.
>>>> We already broke compatibility with cut(1) when we changed the first
>>>> column's width from %6ld to %7ld.  Before that, the output was actually
>>>> aligned with '/bin/ls -l' on my system.
>>> You're right. And of course, the fact that we've had --xml for a long
>>> time should simplify the decision.
>>>
>>> I have a couple of ideas ... will make up a patch over the week-end.
>> r1847384
>>
>> Does two new things; this:
>>
>> $ svn ls -v
>> 1847281 stsp                  Nov 23 16:04 ./
>> 1716820 rhuijben          175 Nov 27  2015 .editorconfig
>> 1659509 rhuijben         3091 Feb 13  2015 .ycm_extra_conf.py
>>  915036 mf                 94 Feb 22  2010 BUGS
>> 1846422 julianfoad       354869 Nov 12 15:26 CHANGES         <<<******!
>> 1833511 julianfoad        14264 Jun 14 16:40 COMMITTERS
>> 1829224 astieger          55966 Apr 15  2018 INSTALL
>> 1801940 kotkov            22834 Jul 14  2017 LICENSE
>> 1845942 brane             42789 Nov 06 18:37 Makefile.in
>>
>>
>> And this:
>>
>> $ svn ls --verbose --human-readable
>> 1847281 stsp                  Nov 23 16:04 ./
>> 1716820 rhuijben         175B Nov 27  2015 .editorconfig
>> 1659509 rhuijben         3.0K Feb 13  2015 .ycm_extra_conf.py
>>  915036 mf                94B Feb 22  2010 BUGS
>> 1846422 julianfoad       347K Nov 12 15:26 CHANGES
>> 1833511 julianfoad        14K Jun 14 16:40 COMMITTERS
>> 1829224 astieger          55K Apr 15  2018 INSTALL
>> 1801940 kotkov            22K Jul 14  2017 LICENSE
>> 1845942 brane             42K Nov 06 18:37 Makefile.in
>>
>>
>> And for example, once GitHub is fixed, this:
>>
>> $ svn ls -vH https://github.com/apache/httpd/trunk
>>   59613 jean.frederic.clere        Nov 23 18:10 ./
>>   59436 ruediger.pluem         15K Oct 26 12:24 .gdbinit
>>   29451 jim.jagielski          13K Jan 04  2017 ABOUT_APACHE
>>   58200 gregg.lewis.smith      68K Feb 26  2018 Apache-apr2.dsw
>>   58200 gregg.lewis.smith      84K Feb 26  2018 Apache.dsw
>>   16350 william.a..rowe.jr    2.6K Aug 24  2007 BuildAll.dsp
>>   57872 gregg.lewis.smith     2.7K Jan 19  2018 BuildBin.dsp
>>   59450 christophe.jaillet     33K Nov 11 09:22 CHANGES
>>   59174 jim.jagielski          49K Aug 09 13:30 CMakeLists.txt
>>
>>
>> -- Brane
>>
> Awesome, thank you!

It's just a damn shame that the '-h' flag is already taken, otherwise we
could be like 'df' and use -h for base-2 units and -H for base-10 units,
whereas now it's -H for base-2 units ... if anyone has any bright ideas
for fixing this omission, please say so.

I'd though about adding a --base-10 flag, so '-H' is base-2 units and
'-H --base-10' would use base-10 units. I do think that the default
should be base-2, because users are probably more used to thinking that
way. Well, at least programmers are, and they are, after all, the main
users of version control.

Ah, right: r1847422 fixes a silly bug in the number scaling, but more
importantly it changes the number formatting to use the locale-specific
decimal separator, to make it consistent with the locale-specific date
abbreviation:

$ env LC_ALL="it_IT.UTF-8" svn ls -vH
1847281 stsp                  Nov 23 16:04 ./
1716820 rhuijben         175B Nov 27  2015 .editorconfig
1659509 rhuijben         3,0K Feb 13  2015 .ycm_extra_conf.py   <<<******!
 915036 mf                94B Feb 22  2010 BUGS
1846422 julianfoad       347K Nov 12 15:26 CHANGES
1833511 julianfoad        14K Giu 14 16:40 COMMITTERS
1829224 astieger          55K Apr 15  2018 INSTALL
1801940 kotkov            22K Lug 14  2017 LICENSE
1845942 brane             42K Nov 06 18:37 Makefile.in



-- Brane


Mime
View raw message