subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Foad <julianf...@apache.org>
Subject Re: [PATCH] Re: [PATCH] A test for "Can't get entries" error
Date Fri, 23 Nov 2018 13:56:19 GMT
Daniel Shahaf wrote:
> Julian Foad wrote on Wed, 21 Nov 2018 16:00 +0000:
> > In reviewing the code I was unable to keep track of all the nuances of 
> > what happens (and should happen) in all the edge cases. Especially when 
> > 'flags & open_path_allow_null' is true and the requested path is a child 
> > of a non-directory like the "/B/mu/iota" in this case: that combination 
> > doesn't seem to be well documented, which makes me wonder what the 
> > callers expect it to do.
> 
> Have you read the docstring of the open_path_allow_null enumerator?

Maybe I was thinking of open_path_last_optional. "If FLAGS & open_path_last_optional is
... non-zero, require all the parent directories to exist as normal ..." when in this case
the parent is not a directory.

-- 
- Julian

Mime
View raw message