subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: [swig-py3][patch] interfacing bytes object instead of str
Date Thu, 22 Nov 2018 00:57:30 GMT
Yasuhito FUTATSUKI wrote on Thu, 22 Nov 2018 08:05 +0900:
> On 11/22/18 3:22 AM, Yasuhito FUTATSUKI wrote:
> > Here is a patch against typemap file core.i, try to change
> > svn_stream_read*() and svn_stream_write() interface to use
> > bytes object.
> 
> Even with this patch, svn_stream_readline() doesn't work well.
> It claims 2nd argment is not bytes object, and returns str object.
> 
> I think it is better that svn_stream_readlin() returns bytes too.
> 

+1.  That function should return bytes, and as no swig-py consumers are
written in py3 there are no compatibility concerns preventing us from
making it so.

> I'll try to fix, though I'm not sure I can.

You're welcome to ask here or on IRC (#svn-dev on freenode) if you
need pointers.

Thanks for looking into it.

Cheers,

Daniel

Mime
View raw message