subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko Čibej <br...@apache.org>
Subject Re: [PATCH] fix repos-to-wc copy dst parents creation
Date Sun, 14 Oct 2018 14:17:31 GMT
On 14.10.2018 15:48, Nikita Slyusarev wrote:
>  
> 04.08.2018, 17:47, "Nikita Slyusarev" <nslus@yandex-team.com>:
>>
>> For everyone's sanity I'd better not only bump the thread, but also
>> resend the patch and the log message I had prepared back then.
>>
>> 14.07.2018, 19:04, "Nikita Slyusarev" <nslus@yandex-team.com
>> <mailto:nslus@yandex-team.com>>:
>>
>>  
>>
>>     [[[
>>     Correctly handle existing parent directories when performing
>>     repos-to-wc copy.
>>
>>     * subversion/libsvn_client/copy.c
>>       (repos_to_wc_copy): If add_parents flag is set and destination
>>     parent
>>       directory exists, but is unversioned, put it under version
>>     control. Wc-to-wc
>>       copy behaves this way, and so should repos-to-wc copy do.
>>
>>     * subversion/tests/cmdline/copy_tests.py
>>       (copy_make_parents_repo_wc,
>>        copy_make_parents_wc_wc): Check behaviour with dst directory
>>     pre-creation
>>       for both repo-to-wc and wc-to-wc test cases.
>>     ]]]
>>      
>>
>  
>  
> Hello, guys, any hope to get this reviewed?


Hey. Thanks for the nudge.

I have just one comment: The two new test scenarios you should be split
into their own test cases. Not only is it bad practice to make a test
case test more than one scenario, it also defeats parallel test execution.

-- Brane


Mime
View raw message