From dev-return-37835-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Wed May 2 17:32:39 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4A7D218065D for ; Wed, 2 May 2018 17:32:39 +0200 (CEST) Received: (qmail 50869 invoked by uid 500); 2 May 2018 15:32:38 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 50854 invoked by uid 99); 2 May 2018 15:32:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 May 2018 15:32:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1D9DD1804C8 for ; Wed, 2 May 2018 15:32:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.822 X-Spam-Level: * X-Spam-Status: No, score=1.822 tagged_above=-999 required=6.31 tests=[KAM_COUK=0.85, RCVD_IN_DNSWL_NONE=-0.0001, SPF_SOFTFAIL=0.972] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id O_wZ9WxEjSZF for ; Wed, 2 May 2018 15:32:32 +0000 (UTC) Received: from know-smtprelay-omc-4.server.virginmedia.net (know-smtprelay-omc-4.server.virginmedia.net [80.0.253.68]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 3CA155F5B1 for ; Wed, 2 May 2018 15:32:32 +0000 (UTC) Received: from localhost ([86.9.48.152]) by cmsmtp with ESMTPA id Dtk2f7MYbplZRDtk2fTkUw; Wed, 02 May 2018 16:32:26 +0100 X-Originating-IP: [86.9.48.152] X-Authenticated-User: codematters@ntlworld.com X-Spam: 0 X-Authority: v=2.3 cv=Vf/Zwmh9 c=1 sm=1 tr=0 a=rSjZpmdkpCpLRM02tfIJ4Q==:117 a=rSjZpmdkpCpLRM02tfIJ4Q==:17 a=NTDmIo5yAAAA:8 a=opCBHtAT2aW2_f72nWkA:9 a=1F6LMcGHgafuNE9Px5x4:22 From: Philip Martin To: Philip Martin Cc: dev@subversion.apache.org Subject: Re: [PATCH] fix libsvn_auth_gnome_keyring.pc w/libsecret References: <20180501212541.GA21668@redhat.com> <87vac7f22n.fsf@codematters.co.uk> Date: Wed, 02 May 2018 16:32:26 +0100 In-Reply-To: <87vac7f22n.fsf@codematters.co.uk> (Philip Martin's message of "Tue, 01 May 2018 23:22:56 +0100") Message-ID: <876046nkdx.fsf@codematters.co.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-CMAE-Envelope: MS4wfGJYf3znf6EhrYUwGjs6UcHXK16SF0BlVGnzaPAmjKNlsbhwVlDGH/2J3joG07a2AHYkRLb58idF9oN9rSSeqBrIc91qXmNb/CyvyUrDiN7AxlV4EKPS pW4yYHk513zzlUAUxRYk781botY9kw8fDVCN97D7danXs44EwUnzrSma+fcfM+Q30R4tY/i4UnCjFmxzI/uPB319d8XW956xuxo= Philip Martin writes: >> Fixes libsvn_auth_gnome_keyring.pc when configured with libsecret, and >> make dependencies private. > > Looks OK to me. Perhaps we should delete the .pc files for gnome/kwallet auth libraries. The corresponding libraries do not really have a public API and I think nodody will ever attempt to link against them. In Subversion the libraries are loaded at runtime using APR's DSO functions so even we do not link against them. -- Philip