From dev-return-37801-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Tue Apr 17 13:34:53 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 99CC6180649 for ; Tue, 17 Apr 2018 13:34:52 +0200 (CEST) Received: (qmail 86973 invoked by uid 500); 17 Apr 2018 11:34:51 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 86959 invoked by uid 99); 17 Apr 2018 11:34:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Apr 2018 11:34:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 72210C734B for ; Tue, 17 Apr 2018 11:34:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.389 X-Spam-Level: X-Spam-Status: No, score=0.389 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id yYOCCjc5Gw1w for ; Tue, 17 Apr 2018 11:34:49 +0000 (UTC) Received: from mail-ua0-f180.google.com (mail-ua0-f180.google.com [209.85.217.180]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id DEB015F126 for ; Tue, 17 Apr 2018 11:34:48 +0000 (UTC) Received: by mail-ua0-f180.google.com with SMTP id q38so12215990uad.5 for ; Tue, 17 Apr 2018 04:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=u3vFzwk0eu+3PX7eRS3oS9mH3YdULMIrk2+trbab4D8=; b=o9g6NIDSXforezSSVnoVIhhlQW9AfwXQikfPB71gcLTNSek8l0isZFSOmGi2EzLM+G SQ6en5vK3ouj7hUNcGZ/73/0SIaFcfMzU0EABj4b/bTLdzhKOvqsCeDsHnFLs1vAv9Yb /mNrezSEhSnMQSTuK8xTJEiFWuIdcHO4qkbqHhKIU2TEfzWONutpr1JUQtQeKSYrGNo5 ESy50mFqkfkpOwk4LoahdVqO1rhcKMR8byUR5SI3ikxZNPOHGr+k/n9KSkfGNWopqqR0 MNLosaivcEke+RRHb+4KcftHTq/aQ7mPqFMU4aH6RvfG0/JwyGcPYeSHLWi68mcc8VqP 9PzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=u3vFzwk0eu+3PX7eRS3oS9mH3YdULMIrk2+trbab4D8=; b=dST2/ajhuC1AjcAugtJ9bH6g2Om4b4cx4ctCSHrxN74LaxFMKepMxtj2Eht4JXE93H 0GSmG+UP1HsVwrAjxTJx/aUOFQY0qGjJypFrT5mSM59JlD9lXyPaqrEbk94tdPnW5wKf jGyjEFHVaBOttkiasLnzGejZUpZVMf1jXhrYMlZFAUntmYpa16CWZlJVLNzo4fW4/uDR kSd0qFZEO6mgC1XiSTMy75MAGNDacWl7kCOmZ453BoKhIiMFdwyQcaP9kGMlBKGc+uas fapjSXtKKZwTfK7V57AwEPQ6XZU1WuRLKtDKkYtGlHnbJ+Kxe7hocslCFqKVzYbM3NLM CUew== X-Gm-Message-State: ALQs6tCg8gzs8CIA65274ZgNtTxv/GhKuCBQ1QEhhswIots5S6gCE6X3 0kDoKSCgmEm/Pur4sMI0GU/zsD3aVGXFX4vBGWM= X-Google-Smtp-Source: AIpwx497cYBXNtXM6LEE9AqHhJgWzUXXO+jEbZQf08xH95yINbgSc6Zw02ryMo4h4YjHSM7UY9qYyaQuKAJtp05cAhs= X-Received: by 10.159.36.133 with SMTP id 5mr1071666uar.124.1523964882179; Tue, 17 Apr 2018 04:34:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.75.221 with HTTP; Tue, 17 Apr 2018 04:34:21 -0700 (PDT) In-Reply-To: <871sfeyth0.fsf@codematters.co.uk> References: <20180417084859.452A93A0057@svn01-us-west.apache.org> <871sfeyth0.fsf@codematters.co.uk> From: Johan Corveleyn Date: Tue, 17 Apr 2018 13:34:21 +0200 Message-ID: Subject: Re: svn commit: r1829344 - in /subversion/trunk/build/ac-macros: lz4.m4 utf8proc.m4 To: Philip Martin Cc: Subversion Development Content-Type: text/plain; charset="UTF-8" On Tue, Apr 17, 2018 at 1:15 PM, Philip Martin wrote: > Johan Corveleyn writes: > >> Maybe we could add an extra hint to the error message along the lines >> of "Maybe you want --with-lz4=internal"? To help self-serviceness and >> avoid mails to the users list ... > > I don't think that is a good recommendation. Internal libraries should > only be used if the OS does not provide the library. OK. I just thought a common scenario of users running into this would be: - Try to build Subversion. - Fail because lz4 library is missing. - "Hmm, haven't seen this before, let's try if we can build without it, let's try --without-lz4". - Error ... Ah, it's required, damn. Now what? Do I have to go looking for yet another dependency of SVN? - Lose time, and perhaps give up. But if it's not recommended, then okay. Or would the following be useful and acceptable? "Subversion requires LZ4. It is recommended you use the most up-to-date version of the LZ4 library provided by your OS. If your OS does not provide one, you can use --with-lz4=internal to use the library included in the SVN release package." A bit long perhaps... It's just a thought ... not terribly important. -- Johan