From dev-return-37755-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Sat Apr 7 21:30:49 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7BF4918064E for ; Sat, 7 Apr 2018 21:30:49 +0200 (CEST) Received: (qmail 14963 invoked by uid 500); 7 Apr 2018 19:30:48 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 14953 invoked by uid 99); 7 Apr 2018 19:30:48 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Apr 2018 19:30:48 +0000 Received: from zulu.local (unknown [77.234.149.125]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id EF31C2AE8 for ; Sat, 7 Apr 2018 19:30:46 +0000 (UTC) Subject: Re: Warnings from the bindings References: <87muyq7cpx.fsf@codematters.co.uk> <87d0zm7c1y.fsf_-_@codematters.co.uk> <941447b5-529a-2299-880c-2babbcd51f13@apache.org> <5fb43f52-daa9-3b36-1900-488e88ad19ec@apache.org> <871sfsjg3m.fsf@codematters.co.uk> <87vad4yppl.fsf@codematters.co.uk> <87tvsodlal.fsf@codematters.co.uk> <87d0zaakmh.fsf@codematters.co.uk> To: dev@subversion.apache.org From: =?UTF-8?Q?Branko_=c4=8cibej?= Openpgp: preference=signencrypt Organization: The Apache Software Foundation Message-ID: <5bafa8cd-39ca-7d75-d87e-47918d10ba6e@apache.org> Date: Sat, 7 Apr 2018 21:30:44 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <87d0zaakmh.fsf@codematters.co.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB On 07.04.2018 21:20, Philip Martin wrote: > Branko Čibej writes: > >> I'll take another look. At the very least this should be using the local >> frame manager object, which is exception-safe, unlike explicitly pushing >> and popping the frame. > ImmutableList::for_each iterates and constructs arbitrary types T. The > problem occurs when T is ExternalItem as the constructor generates local > refs from the get_string_field and get_revision_field calls. It's > possible that we should modify ExternalItem to avoid doing this, but > for_each should also work with arbitrary types and so for_each should > use a local frame. I've comitted the for_each change. Looks good, thanks! -- Brane