subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <br...@apache.org>
Subject Re: Warnings from the bindings
Date Sat, 07 Apr 2018 19:30:44 GMT
On 07.04.2018 21:20, Philip Martin wrote:
> Branko ─îibej <brane@apache.org> writes:
>
>> I'll take another look. At the very least this should be using the local
>> frame manager object, which is exception-safe, unlike explicitly pushing
>> and popping the frame.
> ImmutableList::for_each iterates and constructs arbitrary types T.  The
> problem occurs when T is ExternalItem as the constructor generates local
> refs from the get_string_field and get_revision_field calls.  It's
> possible that we should modify ExternalItem to avoid doing this, but
> for_each should also work with arbitrary types and so for_each should
> use a local frame.  I've comitted the for_each change.

Looks good, thanks!

-- Brane

Mime
View raw message