subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Fwd: [wuzhouhui: Re: width of output of 'svn shelves' is too large]
Date Wed, 04 Apr 2018 18:20:09 GMT
We're getting feedback on 'svn shelve' on users@.  Does anyone want to follow up?

----- Forwarded message from wuzhouhui <1530108435@qq.com> -----

> Date: Sat, 31 Mar 2018 18:17:17 +0800
> From: wuzhouhui <1530108435@qq.com>
> To: Daniel Shahaf <d.s@daniel.shahaf.name>
> Cc: Subversion <users@subversion.apache.org>
> Subject: Re: width of output of 'svn shelves' is too large
> Message-Id: <B20FF364-F7C1-4131-96C9-91A8A8974FE4@qq.com>
> X-Mailer: Apple Mail (2.3273)
> 
> 
> > On 31 Mar 2018, at 1:28 AM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > 
> > wuzhouhui wrote on Mon, Mar 19, 2018 at 19:26:08 +0800:
> >> The width of terminal is 80 column, but the width of output of 'svn shelves'
is 82
> >> at least, I think 80 is better.
> > 
> > Thanks for testing the pre-releases.
> > 
> >> What do you think?
> > 
> > Agreed in principle, but cannot reproduce the original problem.  With current
> > trunk, the output for me is 70 columns.  By code inspection, that should be the
> > case so long as the shelf name is ≤29 characters (plus or minus the length of
> > the right-hand side description, which can vary by ±5 columns).
> > 
> > What version are you testing with?
> 
> Version: subversion-1.10.0-rc1.tar.bz2
> OS: ubuntu 16.04
> Configure args: ./configure --with-lz4=internal
> 
> That's what I encountered:
> 
> > wzh@localhost:/tmp/subversion-1.10.0-rc1/subversion/svn/wc$ ../svn shelves | tee
/tmp/a.out
> > a                                   3 mins old        235 bytes    1 paths changed
> >  
> >  a |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > wzh@localhost:/tmp/subversion-1.10.0-rc1/subversion/svn/wc$ wc -L /tmp/a.out
> > 82 /tmp/a.out
> > wzh@localhost:/tmp/subversion-1.10.0-rc1/subversion/svn/wc$
> 
> It seemed that the max width of shelves's output is 82 column even if the name of shelve
is
> a single char 'a' and the changes is 1 line.
> 
> In addition, I found another issue:
> 1. Create a empty file (named 'a') and version it, then commit.
> 2. Add some contents to file 'a'
> 3. svn shelve a a
> Now, the file 'a' will be deleted, that isn't what I want.
> 

----- End forwarded message -----

Mime
View raw message