From dev-return-37424-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Wed Feb 7 15:34:52 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id EADDD18065B for ; Wed, 7 Feb 2018 15:34:52 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DA7AE160C5B; Wed, 7 Feb 2018 14:34:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2BF3C160C3C for ; Wed, 7 Feb 2018 15:34:52 +0100 (CET) Received: (qmail 61665 invoked by uid 500); 7 Feb 2018 14:34:50 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 61651 invoked by uid 99); 7 Feb 2018 14:34:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Feb 2018 14:34:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8DDBA180282 for ; Wed, 7 Feb 2018 14:34:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.501 X-Spam-Level: * X-Spam-Status: No, score=1.501 tagged_above=-999 required=6.31 tests=[KAM_COUK=0.85, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id PMWBTX4WKXxU for ; Wed, 7 Feb 2018 14:34:47 +0000 (UTC) Received: from know-smtprelay-omc-5.server.virginmedia.net (know-smtprelay-omc-5.server.virginmedia.net [80.0.253.69]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 5208E5F17D for ; Wed, 7 Feb 2018 14:34:47 +0000 (UTC) Received: from localhost ([86.9.48.152]) by cmsmtp with ESMTPA id jQo3e4CEVYgSwjQo3eCFQY; Wed, 07 Feb 2018 14:34:40 +0000 X-Originating-IP: [86.9.48.152] X-Authenticated-User: codematters@ntlworld.com X-Spam: 0 X-Authority: v=2.3 cv=f4lm+t6M c=1 sm=1 tr=0 a=rSjZpmdkpCpLRM02tfIJ4Q==:117 a=rSjZpmdkpCpLRM02tfIJ4Q==:17 a=mV9VRH-2AAAA:8 a=96ZxyOvavaaMKWRovX4A:9 From: Philip Martin To: Julian Foad Cc: Philip Martin , Svn dev Subject: Re: Reviewing 1.10 APIs & compatibility References: <02e94769-17a8-fc9c-30ad-3b71f1b2977b@apache.org> <87wp0ivflr.fsf@codematters.co.uk> <7cf46411-33e5-fdcf-9054-6143936d3ba0@apache.org> Date: Wed, 07 Feb 2018 14:34:39 +0000 In-Reply-To: <7cf46411-33e5-fdcf-9054-6143936d3ba0@apache.org> (Julian Foad's message of "Tue, 6 Feb 2018 17:02:52 +0000") Message-ID: <87wozoc1hc.fsf@codematters.co.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-CMAE-Envelope: MS4wfFdldVl7MHaiyOu+fa4RLgKU+x/xfK5OP5lLH88x0vSIg1wcsqDs1bPpfqH9kiqlmIImjGsWS7XiEIT9awIPIrzGw6bYfHE7lDmpISBX4Xs6ZgqiyHeV RMmfl7Erw2f4VcEeDsJJsmBs4iuLk7uUjjFqlduzOi/ijylU3cAoNC+epVDl0tgKMqu2HF7bpadks/sKyG8Esi7ozsU+BhNSD3iY8RXM7cW3Kga7RsUEhrTc jqMJRH+5Ch+JlrrKJBoHKw== Julian Foad writes: > Philip Martin wrote: >> First I ran the 1.9 testsuite against 1.10 servers >> over http:// and svn://. [...] > > Philip, please can you tell me how you did this? > > [...] >> I also ran the 1.10 testsuite against 1.9 servers over http:// and >> svn://. In order to run the svn:// tests I had to disable part of >> ra-test 10 as the 1.9 server doesn't have r1723865 and the 1.10 >> testsuite would block. > [...] Perhaps I answered the wrong question. If you are asking how I disabled part of ra-test then I simply removed the code and recompiled. Looking at it again I'm not sure why I referred to test 10 as the problem code is in get_dir_test() Index: ../src-1.10/subversion/tests/libsvn_ra/ra-test.c =================================================================== --- ../src-1.10/subversion/tests/libsvn_ra/ra-test.c (revision 1823419) +++ ../src-1.10/subversion/tests/libsvn_ra/ra-test.c (working copy) @@ -604,6 +604,7 @@ get_dir_test(const svn_test_opts_t *opts, SVN_DIRENT_KIND, pool), SVN_ERR_FS_NOT_FOUND); +#if 0 /* Test fetching SVN_DIRENT_SIZE without SVN_DIRENT_KIND. */ SVN_ERR(svn_ra_get_dir2(session, &dirents, NULL, NULL, "", 1, SVN_DIRENT_SIZE, pool)); @@ -611,7 +612,6 @@ get_dir_test(const svn_test_opts_t *opts, ent = svn_hash_gets(dirents, "A"); SVN_TEST_ASSERT(ent); -#if 0 /* ra_serf has returns SVN_INVALID_SIZE instead of documented zero for * for directories. */ SVN_TEST_INT_ASSERT(ent->size, 0); -- Philip