From dev-return-37518-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Sat Feb 24 21:57:35 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A3A76180656 for ; Sat, 24 Feb 2018 21:57:34 +0100 (CET) Received: (qmail 78877 invoked by uid 500); 24 Feb 2018 20:57:33 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 78867 invoked by uid 99); 24 Feb 2018 20:57:33 -0000 Received: from mail-relay.apache.org (HELO mailrelay2-lw-us.apache.org) (207.244.88.137) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 24 Feb 2018 20:57:33 +0000 Received: from zulu.local (unknown [77.234.149.122]) by mailrelay2-lw-us.apache.org (ASF Mail Server at mailrelay2-lw-us.apache.org) with ESMTPSA id 3C52A1945 for ; Sat, 24 Feb 2018 20:57:31 +0000 (UTC) Subject: Re: Subversion1.10.0-rc1 up for testing/signing To: dev@subversion.apache.org References: <5f3f4af4-e1c4-79eb-7586-6461f3fb3d76@apache.org> From: =?UTF-8?Q?Branko_=c4=8cibej?= Organization: The Apache Software Foundation Message-ID: <80b0fddd-c12d-6ba7-0bce-9395ba3d230c@apache.org> Date: Sat, 24 Feb 2018 21:57:28 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB On 24.02.2018 21:55, Julian Foad wrote: > Branko Čibej wrote: >>>    - Warning from JavaHL build: >>> >>>      subversion/bindings/javahl/native/SVNRepos.cpp:371:15: warning: >>> 'svn_repos_load_fs5' >>>            is deprecated [-Wdeprecated-declarations] >>>        SVN_JNI_ERR(svn_repos_load_fs5(repos, >>> dataIn.getStream(requestPool), >> >> I'm assuming we can fix this during the soak period, even if it means >> adding another overload to the JavaHL Repos API, yes? Fixing bindings >> shouldn't extend the soak (or only by a week)? >> >> In other words, it doesn't make sense to block RC1 over this detail. > > We should not require this to be fixed for 1.10.0. > > We have a policy of not calling deprecated APIs from within our own > code, but that is basically for our own convenience -- it does not > matter to the users of our code. We have a requirement that deprecated > APIs are safe and correct to use. Therefore it is fine to release code > like this. > > It can be fixed at leisure, any time. The fix is already done and is approved for backport to 1.10.x (so it gets merged tonight). It adds another API overload to JavaHL, so it really needs to be in .0. -- Brane