From dev-return-37494-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Sun Feb 18 20:07:20 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D215718064D for ; Sun, 18 Feb 2018 20:07:19 +0100 (CET) Received: (qmail 84508 invoked by uid 500); 18 Feb 2018 19:07:18 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 84494 invoked by uid 99); 18 Feb 2018 19:07:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Feb 2018 19:07:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 99555C0096 for ; Sun, 18 Feb 2018 19:07:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.8 X-Spam-Level: X-Spam-Status: No, score=-0.8 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=daniel.shahaf.name header.b=ThXLmlc8; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=H+q3sdDW Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id YAl_2gw4desE for ; Sun, 18 Feb 2018 19:07:16 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id E18495F24C for ; Sun, 18 Feb 2018 19:07:15 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 0163020D8D; Sun, 18 Feb 2018 14:07:09 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute3.internal (MEProxy); Sun, 18 Feb 2018 14:07:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=GGGbNh Sc470MtXQVqRq6nItLvyl3tZMWHmCisnT5XEs=; b=ThXLmlc8/qOPCoPfotolLP G219VQnn7WdMyDBFwXplMK4EX1UJm9zdc6TA5U+zuZDXgunFMOaXCC4TiV0Rbacp VC3IAyiiMUvyzW7YIHKzREDOVWAJddWl7aeLTuqhiydU0zxo3S95W4qCPr6jcdUo LJqz1RUHyx6QttjzFv+UFRP8fLla6w/RnWa1CMwM0gFkPTS22yb9nd1e8nAEKh5u k9jcHDnAUZIHIyI1i5bujatl1sCDweGlZLJ4gF0JX57lC2Ne5BsFza2QEEzgBwoK O5fkOg28Bko3NdunRGpiXGVKR6o8b6Qo8V3wGYfmLEMkGn/st2i+uRud7mPfDkpw == DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=GGGbNh Sc470MtXQVqRq6nItLvyl3tZMWHmCisnT5XEs=; b=H+q3sdDWmA1HOGeD3hWT/w 0YoFJURa55Gt1bR+KbH5o/QMlLbNc8Ug/s0oh/prrr4UMJWFnwxH2jaJByyef31C t/cJ1lZwSlid4VA9BhTpFuy3COYUvw5ju32i85qeEHagOmIgbTZ1TIILags0iErj k4FLOgQVl6rOu0rBRxsyccPVRBWoWNuCWYqWd8az8Z6dZLybKoBgJhEVMnZwu/wv J0agyYVQDIW5NZpw+HVmTWa6t7NJ98ybH5A/zXhrVNNfHjU+IZL9ls7o5Y7MlSMG JOfDMAf9oINiie7HfB4HG964FvBqCDux5DkA6OYgMgPih68ZTMZNaOqwsLjg2i0w == X-ME-Sender: Received: from tarpaulin.shahaf.local2 (bzq-109-64-18-83.red.bezeqint.net [109.64.18.83]) by mail.messagingengine.com (Postfix) with ESMTPA id 8CF93240B6; Sun, 18 Feb 2018 14:07:08 -0500 (EST) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 3zkxFl10Ngz1R9; Sun, 18 Feb 2018 19:07:07 +0000 (UTC) Date: Sun, 18 Feb 2018 19:07:07 +0000 From: Daniel Shahaf To: Karl Fogel Cc: Subversion Developers Subject: Re: [PATCH] Better error message for svn bindings import in mailer.py. Message-ID: <20180218190707.zraxeuyjohiulc2k@tarpaulin.shahaf.local2> References: <874lmlly1l.fsf@red-bean.com> <1518549600.2188387.1269699504.01F0E02A@webmail.messagingengine.com> <877erbkz48.fsf@red-bean.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <877erbkz48.fsf@red-bean.com> User-Agent: NeoMutt/20170113 (1.7.2) Karl Fogel wrote on Sat, Feb 17, 2018 at 16:52:39 -0600: > Daniel Shahaf writes: > >It would be useful to also print the caught exception in case it contains more > >specific information about the cause of the problem… > > > >… but in that case, why not remove the try/except entirely? > > That's a good point. I already committed my original proposed change in > r1824080. Would you like to follow up with a removal of the try/except? Done: r1824690.