From dev-return-37473-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Tue Feb 13 20:20:08 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C4C8D180656 for ; Tue, 13 Feb 2018 20:20:07 +0100 (CET) Received: (qmail 43326 invoked by uid 500); 13 Feb 2018 19:20:06 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 42732 invoked by uid 99); 13 Feb 2018 19:20:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Feb 2018 19:20:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3AC601A068A for ; Tue, 13 Feb 2018 19:20:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.8 X-Spam-Level: X-Spam-Status: No, score=-0.8 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=daniel.shahaf.name header.b=RfvV3VOj; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=JRQbjtQk Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id zGXIPALj-ZbW for ; Tue, 13 Feb 2018 19:20:02 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A40585F296 for ; Tue, 13 Feb 2018 19:20:01 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id BF54020D54; Tue, 13 Feb 2018 14:20:00 -0500 (EST) Received: from web6 ([10.202.2.216]) by compute3.internal (MEProxy); Tue, 13 Feb 2018 14:20:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=sSMsqF 5IZqViWDdWWsNO3ql//QQAx4XPcOyyW5QUi8c=; b=RfvV3VOjkz6YBNc1HBaQsU jUc/1ON+RLlEVTxB00aoWFsdllL0Y+wR/KadzU/WZHBc5NLD8DohzJR1G+GL/DVN WtCUE2WOYBCkxVYTPpCr0ZPr4E0necdXEywT8kI2CxFyzkTJR9lhuriCY4gRXYGt s7dxa9VjuUvPLBCpNSXDOlbZ7WTScFaE/3NSyem0f5e0iUx9EqLwjhrpR0DwvbOc kZSQRbwOxYBYVCVxTxXj/Wsiaikc+mD1WvZv0bfFz5Ofr5YHnv0og4l3+qi4frkY Kcf1O46bSOVbjS6CsU4oA10xtfEzzbeBO/GjdRbOlSudGU5vyQKio3j/1NVS/VcA == DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=sSMsqF 5IZqViWDdWWsNO3ql//QQAx4XPcOyyW5QUi8c=; b=JRQbjtQkn514vTvU/nfiEg V0nFN3jamu/bYHzG1kfsoh4Mad3AyGBdWNue61kTtfuypoWR2sPSvas7QUPscsHs wcon5Km5yMr2TcIqGswgajnvV05fKErbrNQTsl3Zsyur4vUWKslmijPRsdDIzH6C BGuEKjA2/ebRrthNdmRnp+Ou5DfxKo+fxM2c14pK8g5woC5r3R2/CYMYhIY7WP0a 3X6L3yfsdUsGXRw1dNEAckL1+E+k/DUkKokQN/qAL/+Icbop5HM9ONoQM96LlSkb nb5FhC4iDIazjlEETQqOcMRPfIR0rkoKX/qLBkyyw0cdhclVCzOBnh32Os24rs9w == X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id A18CA40FB; Tue, 13 Feb 2018 14:20:00 -0500 (EST) Message-Id: <1518549600.2188387.1269699504.01F0E02A@webmail.messagingengine.com> From: Daniel Shahaf To: Karl Fogel , Subversion Developers MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-fde26eb3 Date: Tue, 13 Feb 2018 19:20:00 +0000 In-Reply-To: <874lmlly1l.fsf@red-bean.com> References: <874lmlly1l.fsf@red-bean.com> Subject: Re: [PATCH] Better error message for svn bindings import in mailer.py. Karl Fogel wrote on Mon, 12 Feb 2018 15:04 -0600: > +++ tools/hook-scripts/mailer/mailer.py (working copy) > @@ -70,23 +70,21 @@ > _MIN_SVN_VERSION =3D [1, 5, 0] >=20=20 > # Import the Subversion Python bindings, making sure they meet our > # minimum version requirements. > try: > import svn.fs > import svn.delta > import svn.repos > import svn.core > except ImportError: > - sys.stderr.write( > - "You need version %s or better of the Subversion Python bindings.\n"= \ > - % ".".join([str(x) for x in _MIN_SVN_VERSION])) > + sys.stderr.write("Unable to import Subversion Python bindings.\n") > sys.exit(1) It would be useful to also print the caught exception in case it contains m= ore specific information about the cause of the problem=E2=80=A6 =E2=80=A6 but in that case, why not remove the try/except entirely? > if _MIN_SVN_VERSION > [svn.core.SVN_VER_MAJOR, > svn.core.SVN_VER_MINOR, > svn.core.SVN_VER_PATCH]: > sys.stderr.write( > "You need version %s or better of the Subversion Python bindings.\n"= \ > % ".".join([str(x) for x in _MIN_SVN_VERSION])) > sys.exit(1)