From dev-return-37449-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Sat Feb 10 20:47:50 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 9B1EB180676 for ; Sat, 10 Feb 2018 20:47:50 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8A236160C3D; Sat, 10 Feb 2018 19:47:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CC0C3160C4D for ; Sat, 10 Feb 2018 20:47:49 +0100 (CET) Received: (qmail 79127 invoked by uid 500); 10 Feb 2018 19:47:48 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 79094 invoked by uid 99); 10 Feb 2018 19:47:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Feb 2018 19:47:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A9E0DC0042; Sat, 10 Feb 2018 19:47:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.82 X-Spam-Level: X-Spam-Status: No, score=-0.82 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=daniel.shahaf.name header.b=jR2w1lVt; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=Rn2qAAh2 Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id s1HpYnZ5H6yT; Sat, 10 Feb 2018 19:47:46 +0000 (UTC) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id C517A5F178; Sat, 10 Feb 2018 19:47:45 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 1245020C87; Sat, 10 Feb 2018 14:47:45 -0500 (EST) Received: from web6 ([10.202.2.216]) by compute3.internal (MEProxy); Sat, 10 Feb 2018 14:47:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=tBrJ14 FcuSxCI+8pyPPdBJguRGxQusSTNU/16G0jdGA=; b=jR2w1lVt0trSsN6CD+tUnj HwHTZfauTBD4ZjomGcZUe+8i7IprolbURx1yLGci5q6A8SyZBccoruuo6cIiRjoj 73WmIvSggm9KM/H52YQilTlc6qd06AOtDA04BbdxlN5L0QiwMVG3oH7SLTx5erzg VRAMzWSC9ir7e877NaoT9m6pcUVECjlgsh57VA1D1iUtA7BBOCTQB9OAS2bbd8ls 0igXd+6XeBI+JnHdzWL/7l4fMbDQoubd4AANmgRT3UJ+yJWdpmuUUJMu4OqYryO3 2/SBnIl9tLY6I85DNmZ+KJu8prVj8u7SCw6C3jDbT2A3fHL2t+A87XNp1Tr0+AUA == DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=tBrJ14 FcuSxCI+8pyPPdBJguRGxQusSTNU/16G0jdGA=; b=Rn2qAAh2TJQmL489ZbaZau NTUEcFC0oDFPQoHkQqJ0FESjAYU1oqHl3SEzREk9h05mKh4wnSCjUVFoyhgxJmuV bmKAppPdEncGoQHcdrdu9vpyu9V7caFpLQjYsy3Dd0sF2lEd+wZY07spveRfzS6S Lz0rYSl77OwNhIbT2IM6VCF3cvVJi0MbSrckk1rdFpbdG9qV+Mb0I99BDX+dEfOj V0pDz7yqm0NAgH7j0hakUBIpdy8OpwWptDo8Yf4G+rki77/3nvw7PTvmb1x9uytW 4T3nAr0GRTibaYLdRB/q6YlYXUsjkjyAEoZZSnmD4Em8HWzqmkGJDZ8eRKQJEp3w == X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id CD9AA4106; Sat, 10 Feb 2018 14:47:44 -0500 (EST) Message-Id: <1518292064.2954274.1266465016.3057C4FE@webmail.messagingengine.com> From: Daniel Shahaf To: dev@subversion.apache.org, commits@subversion.apache.org Cc: stsp@apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-fde26eb3 References: <20180210192605.C5D443A0096@svn01-us-west.apache.org> In-Reply-To: <20180210192605.C5D443A0096@svn01-us-west.apache.org> Subject: Re: svn commit: r1823791 - /subversion/trunk/Makefile.in Date: Sat, 10 Feb 2018 19:47:44 +0000 stsp@apache.org wrote on Sat, 10 Feb 2018 19:26 +0000: > +++ subversion/trunk/Makefile.in Sat Feb 10 19:26:03 2018 > @@ -872,9 +872,7 @@ $(SWIG_PL_DIR)/native/Makefile: $(SWIG_P > -swig-pl_DEPS = autogen-swig-pl libsvn_swig_perl \ > - $(SWIG_PL_DIR)/native/Makefile > -swig-pl: $(swig-pl_DEPS) > +swig-pl: autogen-swig-pl $(SWIG_PL_DIR)/native/Makefile > if test "`$(READLINK_PL) $(SWIG_PL_DIR)`" != "`$(READLINK_PL) $(SWIG_PL_SRC_DIR)`"; then \ > for f in $(SWIG_PL_SRC_DIR)/native/*.c ; do \ > if [ -e "$$f" ] ; then \ Is the removal of swig-pl_DEPS correct? foo_DEPS appears to be a build.conf / build-outputs.mk naming convention: % ag DEPS build | me build/generator/templates/build-outputs.mk.ezt:29:[modules.name]_DEPS =[for modules.deps] [modules.deps][end] build/generator/templates/build-outputs.mk.ezt:103:[target.varname]_DEPS = $([target.varname]_HEADERS) $([target.varname]_OBJECTS)[for target.add_deps] [target.add_deps][end][for target.deps][if-index target.deps first][else] [end][target.deps][end] build/generator/templates/build-outputs.mk.ezt:104:[target.name]: $([target.varname]_DEPS) build/generator/templates/build-outputs.mk.ezt:114:[else][is target.type "i18n"][target.varname]_DEPS =[for target.add_deps] [target.add_deps][end][for target.objects] [target.objects][end][for target.deps] [target.deps][end] build/generator/templates/build-outputs.mk.ezt:115:[target.name]: $([target.varname]_DEPS) build/generator/templates/build-outputs.mk.ezt:116:[else][target.varname]_DEPS =[for target.add_deps] [target.add_deps][end][for target.objdeps] [target.objdeps][end][for target.deps] [target.deps][end] build/generator/templates/build-outputs.mk.ezt:118:[target.filename]: $([target.varname]_DEPS) I suspect that removing swig-pl_DEPS this way is actually an improvement since the assignment in Makefile.in would have conflicted with any possible (future) assignment in build-outputs.mk, but I'm not entirely sure. Presumably, if build-outputs.mk ever contains a definition of swig- pl_DEPS it will also generate a 'swig-pl: $(swig-pl_DEPS)' line. Cheers, Daniel