subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: mailer.py commit says TypeError: must be unicode, not str
Date Thu, 08 Feb 2018 12:35:31 GMT
Troy Curtis Jr wrote on Thu, 08 Feb 2018 03:29 +0000:
> but sure enough, a 'rpm -ql python2-future' reveals:
> ...
> /usr/lib/python2.7/site-packages/builtins
> ...
> 
> That was certainly unexpected..and presumably a bad way to detect
> python3/python2.  Though the case could be
> made that if the code was py3 compatible, and python2-futures brought the
> py3 features, all should be well.  In this case the py3
> compat was only starting to happen, but hadn't finished yet.
> 
> It certainly seems like something to address, the mere presence of the
> compat library causes the bindings to misbehave.
> 
> I'll take a look at it tonight or tomorrow night unless someone beats me to
> it.

So, just to be clear, the problem is that svn/fs.py is not py3
compatible, and having the 'builtins' module under py2 merely
exposes that?  I.e., we have no reason to suspect a bug in the 'future'
package's implementation of builtins.open() under py2.

Cheers,

Daniel

Mime
View raw message